You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[C++] Document VisitArrayInline and type traits #31400
In ARROW-15952, we documented the ArrayVisitor and TypeVisitor classes. But as I discovered in a cookbook PR, you can't subclass these abstract visitors and use type traits. Now I know why most visitor implementations within of Arrow don't subclasses these.
We should instead suggest users simply use the VisitArrayInline and VisitTypeInline with their visitors, and ignore the ArrayVisitor and TypeVisitor classes and associated Accept() methods. In fact, can we deprecate (or even remove) those? Do they add anything valuable?
Activity
asfimport commentedon Mar 21, 2022
Will Jones / @wjones127:
We should also add VisitArrayInline and VisitScalarInline to the API.
asfimport commentedon Mar 29, 2022
David Li / @lidavidm:
Issue resolved by pull request 12717
#12717