Skip to content

[C++] Document VisitArrayInline and type traits #31400

Closed

Description

@asfimport

In ARROW-15952, we documented the ArrayVisitor and TypeVisitor classes. But as I discovered in a cookbook PR, you can't subclass these abstract visitors and use type traits. Now I know why most visitor implementations within of Arrow don't subclasses these.

We should instead suggest users simply use the VisitArrayInline and VisitTypeInline with their visitors, and ignore the ArrayVisitor and TypeVisitor classes and associated Accept() methods. In fact, can we deprecate (or even remove) those? Do they add anything valuable?

Reporter: Will Jones / @wjones127
Assignee: Will Jones / @wjones127

Related issues:

PRs and other links:

Note: This issue was originally created as ARROW-15975. Please see the migration documentation for further details.

Activity

  1. asfimport commented on Mar 21, 2022

    @asfimport
    Author

    Will Jones / @wjones127:
    We should also add VisitArrayInline and VisitScalarInline to the API.

  2. asfimport commented on Mar 29, 2022

    @asfimport
    Author

    David Li / @lidavidm:
    Issue resolved by pull request 12717
    #12717

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Type

No type

Projects

No projects

    Milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions