You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[C++][Flight] DoExchange doesn't support dictionary replacement #26727
Looking at the server DoExchangeMessageWriter implementation, it seems to assume that the dictionary values for a given dictionary-encoded field will never change accross record batches.
I think we can do the same trick we did for DoGet were we use an internal ipc::RecordBatchWriter and our own IpcPayloadWriter to generate the FlightPayload so we can get rid of the manual dictionary collection and generation. @lidavidm what do you think?
Activity
asfimport commentedon Dec 2, 2020
Antoine Pitrou / @pitrou:
cc @lidavidm
raulcd commentedon Aug 19, 2025
The
DoExchangecode that generates the messages and the payloads does not reuse the code changed on server.cc here:It uses its own implementation here:
arrow/cpp/src/arrow/flight/transport_server.cc
Lines 163 to 256 in 066b216
I think we can do the same trick we did for DoGet were we use an internal
ipc::RecordBatchWriterand our ownIpcPayloadWriterto generate theFlightPayloadso we can get rid of the manual dictionary collection and generation.@lidavidm what do you think?
lidavidm commentedon Aug 20, 2025
Yes, well, that's why there's a comment there saying we should do that :)
apacheGH-26727: [C++][Flight] Use ipc::RecordBatchWriter with custom …
GH-26727: [C++][Flight] Use ipc::RecordBatchWriter with custom IpcPay…
raulcd commentedon Aug 26, 2025
Issue resolved by pull request 47410
#47410
apacheGH-26727: [C++][Flight] Use ipc::RecordBatchWriter with custom …