Skip to content

[Java] Remove value boxing/unboxing for ApproxEqualsVisitor #22828

Closed

Description

@asfimport

As discussed in #5195 (comment), there are some problems with the current ways of comparing floating point vectors, we solve them in this PR:

  1. there are if statements/duplicated members in ApproxEqualsVisitor, making the code redundant and less clear.
  2. the comparion of float4 and float8 are based on wrapped objects Float and Double, which may have performance penalty.

Reporter: Liya Fan / @liyafan82
Assignee: Liya Fan / @liyafan82

PRs and other links:

Note: This issue was originally created as ARROW-6458. Please see the migration documentation for further details.

Activity

  1. asfimport commented on Sep 17, 2019

    @asfimport
    Author

    Micah Kornfield / @emkornfield:
    Issue resolved by pull request 5304
    #5304

  2. added this to the 0.15.0 milestone on Jan 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Type

No type

Projects

No projects

    Milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions