Repository navigation
[Parquet] perf: Create Utf8/BinaryViewArray directly rather than via ArrayData - #9121
Merged
Merged
Conversation
alamb
commented
Jan 9, 2026
| pub fn into_array(self, null_buffer: Option<Buffer>, data_type: &ArrowType) -> ArrayRef { | ||
| let len = self.views.len(); | ||
| let views = Buffer::from_vec(self.views); | ||
| let views = ScalarBuffer::from(self.views); |
Contributor
Author
There was a problem hiding this comment.
The new formulation is simpler too, which is a nice side effect
This comment was marked as outdated.
This comment was marked as outdated.
alamb
marked this pull request as ready for review
January 9, 2026 15:19
Closed
1 task done
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
alamb
marked this pull request as draft
January 10, 2026 12:11
Contributor
Author
|
run benchmark arrow_reader |
Contributor
Author
|
This appears to show reading StringView getting slower. I will try and reproduce |
|
🤖 |
This comment was marked as outdated.
This comment was marked as outdated.
alamb
marked this pull request as ready for review
January 13, 2026 12:17
Contributor
Author
|
🤔 looks like this maybe made things slower -- will investigate |
alamb
marked this pull request as draft
January 13, 2026 12:21
Contributor
Author
|
I could not reproduce the benchmark results locally However, note the number of outliers found I will see if the benchmark needs adjusting (perhaps with more rows, etc) |
This comment was marked as outdated.
This comment was marked as outdated.
1 similar comment
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
alamb
marked this pull request as ready for review
January 15, 2026 12:17
…b/arrow-rs into alamb/less_parquet_view_allocations
This comment was marked as outdated.
This comment was marked as outdated.
alamb
commented
Jan 15, 2026
| let views = ScalarBuffer::from(self.views); | ||
| let nulls = null_buffer | ||
| .map(|b| NullBuffer::new(BooleanBuffer::new(b, 0, len))) | ||
| .filter(|n| n.null_count() != 0); |
Contributor
Author
There was a problem hiding this comment.
replicates the behavior of ArrayDataBuilder in
|
🤖: Benchmark completed Details
|
|
🤖 |
|
🤖: Benchmark completed Details
|
|
🤖 |
|
🤖: Benchmark completed Details
|
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
Contributor
Author
|
The benchmakrs now show a small but repeatable improvement for the array types. I am not sure how real it is but I am now convinced this PR is an improvement |
Contributor
|
I ran the benchmark for "arrow_array_reader/BinaryViewArray/dictionary encoded, optional, half NULLs" locally with |
Contributor
Author
|
Thank you for double checking @jhorstmann and for the reviews @jhorstmann and @scovich |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
make_array) #9061Rationale for this change
ArrayData(1% improvement) #9120Creating Arrays via ArrayData /
make_arrayhas overhead (at least 2 Vec allocations) compared to simply creating the arrays directlyViewArrays also have an extra Vec allocation (to hold their buffers)
What changes are included in this PR?
Update the parquet reader to create ViewArrays directly
Are these changes tested?
By CI
Are there any user-facing changes?