You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[Java] java-jars fails with "We have duplicated artifacts attached" #92
That's due to the source maven plugin update coming with new Apache POM. On some profile, the source and jar maven plugins are executed by the parent Apache POM and by the project pom. So we have a dual execution, so dual artifacts. It's what I saw on Apache projects. I gonna take a look if it's the same here in Arrow.
@lidavidm I feel like this is the PR which could have broken the CIs. Though java-jars pass in this PR itself, a change made in another PR followed by this merge could have triggered it. It is very hard to predict this since in PR apache/arrow#41309 the java-jars failure is clouded by the C++ filesystem issue which was fixed recently. But that PR has some changes in plugins. But I cannot exactly pin-point what change is causing it.
@vibhatha I don't think that the plugin-plugin update is the root cause of the problem.
IMHO, I'm suspecting more this commit 9090e67 as it updated to Apache POM 31.
I think, we hit the same issue as in my PR (apache/arrow#39215). We had similar issue there (due to Apache POM version bump as well). Let me double check if it's the same and eventually leverage the reproducible build PR to fix that 😄
Activity
lidavidm commentedon May 2, 2024
@vibhatha or @jbonofre, any idea? It's unclear when exactly this popped up since the test was blocked by apache/arrow#41470 until just now
vibhatha commentedon May 2, 2024
Would it be the recent maven build changes, my best guess would be the last build PR, but I can't be sure. Though I didn't notice it before that.
vibhatha commentedon May 2, 2024
Checking my recent crossbow usage
8 days ago: passes
apache/arrow#40340 (comment)
6 days ago: fails
apache/arrow#40340 (comment)
vibhatha commentedon May 2, 2024
I know this doesn't help, but at least it should have happened sometime after 8 days ago.
lidavidm commentedon May 2, 2024
Do you think you could bisect it? Or at least figure out which commits are possible causes in that time range?
jbonofre commentedon May 2, 2024
That's due to the source maven plugin update coming with new Apache POM. On some profile, the source and jar maven plugins are executed by the parent Apache POM and by the project pom. So we have a dual execution, so dual artifacts. It's what I saw on Apache projects. I gonna take a look if it's the same here in Arrow.
vibhatha commentedon May 2, 2024
@lidavidm I am looking into it too.
But seems like @jbonofre has a good pointer to it.
vibhatha commentedon May 2, 2024
@lidavidm I feel like this is the PR which could have broken the CIs. Though java-jars pass in this PR itself, a change made in another PR followed by this merge could have triggered it. It is very hard to predict this since in PR apache/arrow#41309 the java-jars failure is clouded by the C++ filesystem issue which was fixed recently. But that PR has some changes in plugins. But I cannot exactly pin-point what change is causing it.
cc @jbonofre WDYT?
jbonofre commentedon May 2, 2024
@vibhatha I don't think that the plugin-plugin update is the root cause of the problem.
IMHO, I'm suspecting more this commit 9090e67 as it updated to Apache POM 31.
Let me check locally.
vibhatha commentedon May 2, 2024
Yes, this is the PR I am also suspicious about. I am going to wait for your response. Thanks for looking into this @jbonofre
jbonofre commentedon May 2, 2024
I think, we hit the same issue as in my PR (apache/arrow#39215). We had similar issue there (due to Apache POM version bump as well). Let me double check if it's the same and eventually leverage the reproducible build PR to fix that 😄
lidavidm commentedon May 2, 2024
This will become a release blocker at some point but I suppose 17.0.0 is still a bit off
jbonofre commentedon May 2, 2024
@lidavidm agree, so let me tackle that ! At your service 😄
lidavidm commentedon May 2, 2024
It's much appreciated :)
jbonofre commentedon May 2, 2024
@lidavidm my pleasure, always happy to help 😄
GH-41490: [Java] Use macos-12 for building C++ libraries
jbonofre commentedon May 23, 2024
@lidavidm @vibhatha
The problem is in
java_full_build.shin crossbow: https://github.com/apache/arrow/blob/c8f89d06bb79909dbd52d7d1504bdcadb220fadd/ci/scripts/java_full_build.sh#L50It explicitely calls
source:jargoal whereas it's already done by Apache POM 31.IMHO, the
java_full_build.shshould only do:If agree, I can create a PR to change this pipeline.
vibhatha commentedon May 23, 2024
@jbonofre it could be needed in apache/arrow#41772 PR itself?
lidavidm commentedon May 24, 2024
Ok, we can test in CI and confirm. Thanks for digging into this!
lidavidm commentedon Jan 10, 2025
No longer relevant.