Repository navigation
fix(app): raise busy tab spinner contrast in dark theme - #62074
Conversation
There was a problem hiding this comment.
The change looks correct. I checked it by reading the code but couldn't run it here: it's a web/desktop app change, and no browser was available to bring up the app.
The new rule targets the same element as ActivityRing's own color rule and is more specific, so it wins. data-color-scheme is always set on the document root by the theme code, including when the theme is set to "system", so dark users get the brighter spinner either way. The shared ActivityRing/Spinner are untouched, which follows the Loading Indicators rule in packages/app/AGENTS.md. I'm relying on your before/after screenshots and computed colours for the visual result.
Public API: unchanged.
No blocking concerns.
Related: #62026
There was a problem hiding this comment.
The new commit only merges dev, so this pull request's diff is unchanged and my earlier review still applies. The changes it brings in don't affect the tab spinner or the theme tokens. I didn't run it in a browser here. Public API: unchanged. No concerns.
Refs #62026
In dark theme the busy tab spinner was nearly invisible. It uses
--v2-icon-icon-muted, which is grey-600 (#808080) in both themes, and most of the spinner's dots rest at 20% opacity. Against the dark tab background (#080808/#161616) that comes out at about#2b2b2b, so only the single moving dot showed.The busy tab spinner now uses
--v2-icon-icon-base(grey-400,#dbdbdb) in dark theme. Light theme keepsicon-muted; its screenshots are pixel-identical before and after.tab-nav.css. The sharedActivityRing/Spinnerand their other callers (home list, command palette, inbox) are unchanged, per the Loading Indicators rule inpackages/app/AGENTS.md.Checked on the mocked e2e server: the computed spinner color is
rgb(219, 219, 219)in dark andrgb(128, 128, 128)in light.No feature flag; this is a styling fix.
Before:
After:
Visual
Added by the opencode bot (AI-generated).
Related: #62026