Skip to content
This repository was archived by the owner on Nov 22, 2024. It is now read-only.

fix(dom): add img attributes - #367

Merged
PatrickJS merged 1 commit into
angular:masterfrom
wesleycho:fix/img-attrs
Apr 18, 2016
Merged

PatrickJS merged 1 commit into
angular:masterfrom
wesleycho:fix/img-attrs

Conversation

@wesleycho

Copy link
Copy Markdown
Contributor
  • Please check if the PR fulfills these requirements
  • The commit message follows our guidelines: https://github.com/angular/universal/blob/master/CONTRIBUTING.md#commit-message-format
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)
  • What modules are related to this pull-request
  • express-engine
  • grunt-prerender
  • gulp-prerender
  • hapi-engine
  • preboot
  • universal-preview
  • universal
  • webpack-prerender
  • What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
    remove unused proxy imports from some test files
  • What is the current behavior? (You can also link to an open issue here)
  • What is the new behavior (if this is a feature change)?
  • Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)
    No
  • Other information:
  • Add img attributes to ATTRIBUTES constant so setElementProperty can find them

This should fix #331.

- Add img attributes to `ATTRIBUTES` constant so `setElementProperty` can find them
@PatrickJS
PatrickJS merged commit d397dcb into angular:master Apr 18, 2016
@wesleycho
wesleycho deleted the fix/img-attrs branch April 18, 2016 19:40
@angular-automatic-lock-bot

Copy link
Copy Markdown

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot Bot locked and limited conversation to collaborators Sep 5, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

server side rendering of img src attribute within ngFor-collection coming from an http call

2 participants