Skip to content
This repository was archived by the owner on Nov 22, 2024. It is now read-only.
This repository was archived by the owner on Nov 22, 2024. It is now read-only.

Optional route params with pre-rendered views #275

Closed

Description

@zanettin

Related to this issue => angular/router#397 I'm not sure if this an issue or a missconfig from my side. Do I need to specify the route on the node side specialy or is it a bug from the router itself?

issue assigned to: @alexpods

Activity

  1. PatrickJS commented on Feb 15, 2016

    @PatrickJS
    Contributor

    We created our own version of Location Platform so this could really be our fault with the way we're managing the location. If it works on client then it should work with the server rendered view

  2. zanettin commented on Feb 15, 2016

    @zanettin
    Author

    Thanks for your fast reply. I'll close the other issue on angular/router.

  3. changed the title [-]optional route params (Question / Bug?)[/-] [+]Optional route params with pre-rendered views[/+] on Feb 15, 2016
  4. PatrickJS commented on Feb 26, 2016

    @PatrickJS
    Contributor

    @alexpods will take this issue

  5. alexpods commented on Mar 1, 2016

    @alexpods

    @zanettin @gdi2290 The bug is in core router library. More precisely it's here. As you can see urlParams are used only in _stringifyMatrixParams() which is called only if we have auxInstructions (see here). So if we don't have auxilary routes then urlParams will never be used.

    @zanettin Could you open the issue in core angular2 repository?

    UPDATE
    toLinkUrl() is called here

  6. zanettin commented on Mar 1, 2016

    @zanettin
    Author

    thanks for your time @alexpods! i've re-opened the issue on the core router repo.

  7. alexpods commented on Mar 2, 2016

    @alexpods

    @zanettin I've also opened the issue in the core repository angular/angular#7367. I think the core team will be more active to close the issue there (at least I hope so).

  8. ganeshkbhat commented on Mar 2, 2016

    @ganeshkbhat
  9. ganeshkbhat commented on Mar 2, 2016

    @ganeshkbhat

    Thank you... my bad.

  10. angular-automatic-lock-bot commented on Sep 4, 2019

    @angular-automatic-lock-bot

    This issue has been automatically locked due to inactivity.
    Please file a new issue if you are encountering a similar or related problem.

    Read more about our automatic conversation locking policy.

    This action has been performed automatically by a bot.

  11. locked and limited conversation to collaborators on Sep 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions