You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
This repository was archived by the owner on Sep 5, 2024. It is now read-only.
Repository navigation
fix secondary placeholder problem in chips - #3804
@topherfangio, I have unit tests demonstrating issues #2770 and #4476. (Currently there are no unit tests for the placeholder feature of mdChips input.) I've created PR #6535 with those tests and the related fix. (The fix is a single line.)
I wrote a test to match the issue PR a5dba2a is trying to fix. However, there is much other mdChips code that fails to check if the ngModel is defined. There seems to be an inherent assumption that ngModel is defined or that catastrophic failure is preferred when it isn't. It may be better to separate this issue and PR from issues #2770 and #4476.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
needs: feedbackThe issue creator or community need to respond to questions in this issueneeds: investigationThe cause of this issue is not well understood and needs to be investigated by the team or community
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.