Skip to content
This repository was archived by the owner on Sep 5, 2024. It is now read-only.
This repository was archived by the owner on Sep 5, 2024. It is now read-only.

select: remove support for md-multiple #9705

Open

Description

@bmbarker90

Actual Behavior:

  • What is the issue? * When the expression in ng-multiple evaluates to true, md-select-value updates appropriately but md-select-menu does not change to a multi-select.
  • What is the expected behavior? When ng-multiple evaluates to true, it should change md-select-menu to a multi-select.

CodePen (or steps to reproduce the issue): *

  • CodePen Demo which shows your issue: http://codepen.io/anon/pen/Zpyzyq?editors=1010
  • Details: ng-multiple set on the Result select evaluates to true when Multi Select is selected in the type select. The Result select should be a multi-select, but it is not.

Angular Versions: *

  • Angular Version: v1.5.5
  • Angular Material Version: v1.1.1

Additional Information:

  • Browser Type: * Chrome
  • Browser Version: * Version 53.0.2785.116 (64-bit)
  • OS: * OS X El Capitan Version 10.11.6
  • Stack Traces:

Shortcut to create a new CodePen Demo.
Note: * indicates required information. Without this information, your issue may be auto-closed.

Do not modify the titles or questions. Simply add your responses to the ends of the questions.
Add more lines if needed.

Activity

  1. benreibriongos commented on Oct 6, 2016

    @benreibriongos

    Your code is working with multiple select with no checkbox but you can select items same with the checkbox. I'm using chrome Version 53.0.2785.143 m in windows 10.

  2. bmbarker90 commented on Oct 6, 2016

    @bmbarker90
    Author

    Right, but checkboxes should be showing. If I just hard-code multiple="true" in the html, then checkboxes do show for each option

  3. devversion commented on Oct 11, 2016

    @devversion
    Member

    Can confirm this. @topherfangio Do you want to take a look at this?

    Seems to be a major bug.

  4. zbjornson commented on Oct 22, 2016

    @zbjornson

    ngMultiple was dropped from angular core in 1.2.0, though, because it didn't work:

    angular/angular.js#2113
    https://github.com/angular/angular.js/blob/master/CHANGELOG.md#120rc1-spooky-giraffe-2013-08-13
    angular/angular.js@d87fa00
    angular/angular.js#1484

    (We hit this problem also, but can work-around it.)

  5. wingoku commented on Jan 5, 2017

    @wingoku

    Checkbox isn't visible in my md-select either. I have hardcoded the multiple=true

  6. changed the title [-]ng-multiple does not work on md-select[/-] [+]select: ng-multiple does not work[/+] on Jun 6, 2018
  7. changed the title [-]select: ng-multiple does not work[/-] [+]select: remove support for ng-multiple[/+] on Jun 6, 2018
  8. modified the milestones: - Backlog, 1.2.0 on Jun 6, 2018
  9. 2 remaining items

  10. Splaktar commented on Jun 6, 2018

    @Splaktar
    Contributor

    I am going to use this issue to track the removal of support for ng-multiple in AngularJS Material, so that we can match up with AngularJS 1.2.0+. This will be considered a breaking change, so it is targeted to 1.2.0.

    Tracking the evaluation of the argument passed into multiple and ng-multiple will be handled in #3068.

  11. added
    P2: requiredIssues that must be fixed.
    a11yThis issue is related to accessibility
    and removed
    P3: importantImportant issues that really should be fixed when possible.
    on Nov 3, 2019
  12. Splaktar commented on Jul 30, 2020

    @Splaktar
    Contributor

    Our version of ng-multiple has been changed to md-multiple in 1.2.0. We could consider removing it completely in the future.

  13. modified the milestones: 1.2.0, 1.3.0 on Jul 30, 2020
  14. changed the title [-]select: remove support for ng-multiple[/-] [+]select: remove support for md-multiple[/+] on Jul 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

- Breaking ChangeP4: minorMinor issues. May not be fixed without community contributions.a11yThis issue is related to accessibility

Type

No type

Projects

No projects

    Milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions