This repository was archived by the owner on Sep 5, 2024. It is now read-only.
Repository navigation
This repository was archived by the owner on Sep 5, 2024. It is now read-only.
FAB icon offset with ui-sref instead of ng-click #7087
Description
Using md-fab-trigger with ui-sref instead of ng-click breaks the icon alignment. Works in 1.0.5 but not on master but I can't quite pin it down to a commit.
ui-sref becomes an anchor while ng-click becomes a button.
md-fab-trigger
md-button.md-fab.md-primary(aria-label="foo" ui-sref="foo.bar")
md-tooltip(md-direction="left") Foo
md-icon(md-svg-icon="editor:mode_edit")
Activity
topherfangio commentedon Feb 10, 2016
This doesn't appear to be limited to the speed dial, it looks like it is affecting all FABs: http://codepen.io/topherfangio/pen/eJbWPd?editors=1000
Notice how the Cake FAB in the demo above is offset because I added the
ui-srefattribute. Still trying to track it down.[-]md-fab-speed-dial icon offset with ui-sref instead of ng-click[/-][+]FAB icon offset with ui-sref instead of ng-click[/+]topherfangio commentedon Feb 10, 2016
Appears to be related to this commit: b70234e
@devversion Can you explain why you removed the FAB's
line-heightin the above commit? I don't see anything in the commit message about it and it's causing this issue. Might need to revert that change, but wanted to make sure it wasn't fixing something else.devversion commentedon Feb 10, 2016
@topherfangio That wasn't me :), seems that Thomas modified the commit. See actual PR #5748
kuhnroyal commentedon Feb 10, 2016
Nice find. I messed around with the dev tools for an hour and didn't locate it. Silly me.
topherfangio commentedon Feb 10, 2016
@devversion Thanks for the info; I'll touch base with @ThomasBurleson to get this thoughts.
@kuhnroyal I too messed around in the dev tools for a while and didn't find it. I finally just looked at the history of the
button.scssfiguring it would have been changed and found it 😄fix(docs, demo): tooltip mdDelay documented and demo
topherfangio commentedon Feb 11, 2016
Talked to Thomas, it appears that removing this line fixed an issue with the FABs on the tooltip demo. We discussed re-adding this line and figuring out a different way to fix the tooltip issue. I am investigating now.
devversion commentedon Feb 11, 2016
@topherfangio Okay great! 👍 Thanks
fix(FAB): Re-add line-height to fix ui-sref issues.