Skip to content
This repository was archived by the owner on Sep 5, 2024. It is now read-only.
This repository was archived by the owner on Sep 5, 2024. It is now read-only.

Support for required field indicator #6647

Closed

Description

@ThomasBurleson
No description provided.

Activity

  1. added this to the 1.2.0 milestone on Jan 12, 2016
  2. devversion commented on Jan 12, 2016

    @devversion
    Member

    Is this related to an Asterisk? Or what is meant by that?

  3. bourey commented on Jan 12, 2016

    @bourey

    Yes. Here's a link to the latest Material spec for required fields: https://www.google.com/design/spec/components/text-fields.html#text-fields-required-fields

  4. devversion commented on Jan 12, 2016

    @devversion
    Member

    Oh okay I was wondering, because I already created a PR, which is ready for merge, a few days ago.
    See #6518 Whats now 😄 ?

  5. added
    P3: importantImportant issues that really should be fixed when possible.
    and removed on Jan 13, 2016
  6. modified the milestones: 1.2.0, on Jan 15, 2016
  7. devversion commented on Feb 8, 2016

    @devversion
    Member

    @ThomasBurleson Needs to be closed

  8. kuhnroyal commented on Feb 10, 2016

    @kuhnroyal

    This is very nice, could you add that to md-select as well? Should be a quick fix and keeps the inputs consistent. Maybe even datepicker/autocomplete?

  9. kuhnroyal commented on Feb 10, 2016

    @kuhnroyal

    Two things I noticed:

    • doesn't work with ng-required
    • asterisk is always red when the field is focused, should probably have the theme color until it is invalid?
  10. devversion commented on Feb 10, 2016

    @devversion
    Member

    Can't reproduce. Maybe create another issue with a demo. Already noticed the ng-required problem, but this relates to the given compontents.

  11. kuhnroyal commented on Feb 10, 2016

    @kuhnroyal

    https://material.angularjs.org/HEAD/demo/input
    Focus one of the required fields, label is blue and asterisk is red.

  12. devversion commented on Feb 10, 2016

    @devversion
    Member

    @kuhnroyal - See #6978, everything works as expected. The only thing which is an issue, is the ng-required

  13. kuhnroyal commented on Feb 10, 2016

    @kuhnroyal

    @devversion Yea I just checked the spec, thanks.

  14. devversion commented on Feb 10, 2016

    @devversion
    Member

    @kuhnroyal Can you create a new issue for the ng-required, then I can reference it correctly?

  15. kuhnroyal commented on Feb 10, 2016

    @kuhnroyal

    Created #7105 to track ng-required support.

  16. corentin-gautier commented on Apr 7, 2016

    @corentin-gautier

    @devversion is there a support for the required asterisk on md-select ?

  17. self-assigned this
    on Apr 7, 2016
  18. devversion commented on Apr 7, 2016

    @devversion
    Member

    @corentin-gautier No not yet, please file another issue and ping me there.

  19. removed this from the - Backlog milestone on Feb 23, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

P3: importantImportant issues that really should be fixed when possible.g3: reportedThe issue was reported by an internal or external product team.

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions