flex-order doesn't work as expected #5646

Activity

1. topherfangio commented on Nov 10, 2015

   

   topherfangio

   on Nov 10, 2015

   Contributor

   More actions

   @smashercosmo What version are you using? I remember seeing a recent commit (7264cab possibly) that added this support.
2. topherfangio

   added

   needs: more infoThe issue does not contain enough information for the team to determine if it is a real bugThe issue does not contain enough information for the team to determine if it is a real bug

   on Nov 10, 2015
3. smashercosmo commented on Nov 10, 2015

   

   smashercosmo

   on Nov 10, 2015

   Author

   More actions

   @topherfangio I just looked at the sources in master and what I see is

   @mixin flex-order-for-name($sizes:null) {
     @if $sizes == null {
       $sizes : '';
   
       .flex-order {
        order : 0;
       }
     }
   
     @for $i from 0 through 19 {
       $order : '';
       $suffix : '';
   
       @each $s in $sizes {
         @if $s != '' { $suffix : '#{$s}-#{$i}'; }
         @else        { $suffix : '#{$i}';       }
   
         $order : '.flex-order-#{$suffix}';
       }
   
       #{$order} {
         order: #{$i};
       }
     }
   }
4. smashercosmo commented on Nov 11, 2015

   

   smashercosmo

   on Nov 11, 2015

   Author

   More actions

   @topherfangio so no negative values as you see)
5. topherfangio commented on Nov 11, 2015

   

   topherfangio

   on Nov 11, 2015

   Contributor

   More actions

   It looks like this was added and then removed pretty quickly.

   @ThomasBurleson - When you get a chance, you provide some insight?
6. smashercosmo commented on Nov 16, 2015

   

   smashercosmo

   on Nov 16, 2015

   Author

   More actions

   @ThomasBurleson any response on that?
7. ThomasBurleson

   added

   ui: flexbox

   on Dec 4, 2015
8. ThomasBurleson

   added this to the 1.0-rc7 milestone on Dec 4, 2015
9. ThomasBurleson

   self-assigned this

   on Dec 4, 2015
10. ThomasBurleson commented on Dec 4, 2015

    

    ThomasBurleson

    on Dec 4, 2015

    Contributor

    More actions

    @smashercosmo - I do not recall why it was redacted. I will restore with:

    @mixin flex-order-for-name($sizes:null) {
      @if $sizes == null {
        $sizes : '';
    
        .flex-order {
         order : 0;
        }
      }
    
      @for $i from -10 through 10 {
        $order : '';
        $suffix : '';
    
        @each $s in $sizes {
          @if $s != '' { $suffix : '#{$s}-#{$i}'; }
          @else        { $suffix : '#{$i}';       }
    
          $order : '.flex-order-#{$suffix}';
        }
    
        #{$order} {
          order: #{$i};
        }
      }
    }
11. ThomasBurleson

    added a commit that references this issue on Dec 4, 2015

    update(docs, layout): fix breakpoints, documentation, and gettingStarted

    ...

    This issue will close once commit 887927c is merged into the 'master' branch.

    887927c
12. ThomasBurleson commented on Dec 4, 2015

    

    ThomasBurleson

    on Dec 4, 2015

    Contributor

    More actions

    Fixes are pending with #6082
13. ThomasBurleson

    added

    pr: merge readyThis PR is ready for a caretaker to reviewThis PR is ready for a caretaker to review

    and removed

    needs: more infoThe issue does not contain enough information for the team to determine if it is a real bugThe issue does not contain enough information for the team to determine if it is a real bug

    on Dec 4, 2015
14. ThomasBurleson

    closed this as completedin f6e97a0on Dec 4, 2015