This repository was archived by the owner on Sep 5, 2024. It is now read-only.
Repository navigation
This repository was archived by the owner on Sep 5, 2024. It is now read-only.
mdIcon in mdListItem gets not wrapped with a button when mdListItem does not have a ngClick #3928
Description
If you build a mdListItem without a ng-click attribute the containing mdIcons with a ng-click attribute will not be wrapped with a md-button element. I think this is a strange behaviour.
<md-list-item ng-repeat="person in people">
<p>{{ person.name }}</p>
<md-icon md-svg-icon="communication:messenger" ng-click="doSecondaryAction($event)" aria-label="Open Chat" class="md-secondary md-hue-3" ng-class="{'md-primary': person.newMessage}"></md-icon>
</md-list-item>
I would blame the if statement at line 80 in the list.js
Here is a codepen example.
Activity
marcysutton commentedon Jul 28, 2015
Yep, that's a bug. That icon needs to be made into a button to be actionable.
[-]mdListItem icon wont wrapped with button without ngClick on the mdListItem[/-][+]mdListItem icon gets not wrapped with a button without ngClick on the mdListItem[/+][-]mdListItem icon gets not wrapped with a button without ngClick on the mdListItem[/-][+]mdListItem icon gets not wrapped with a button when mdListItem does not have a ngClick[/+][-]mdListItem icon gets not wrapped with a button when mdListItem does not have a ngClick[/-][+]mdIcon in mdListItem gets not wrapped with a button when mdListItem does not have a ngClick[/+]gligoran commentedon Aug 27, 2015
+1 and don't limit it to
ngClick.ngHref,href, and probably some others would be welcome additions.18 remaining items
fix(list): wrapping secondary if it has ng-click