Skip to content
This repository was archived by the owner on Jan 4, 2026. It is now read-only.

Make theme swapping css-based and clean up tests - #188

Merged
jelbourn merged 15 commits into
angular:masterfrom
jelbourn:theming-fixup
Jun 19, 2017
Merged

jelbourn merged 15 commits into
angular:masterfrom
jelbourn:theming-fixup

Conversation

@jelbourn

@jelbourn jelbourn commented Jun 18, 2017 •

Copy link
Copy Markdown
Contributor

The commits for this PR should be preserved for merging.

Changes:

  • Add CSS classes to SVGs so that the colors can be changed via CSS
  • Add mixin for stamping out styles for those SVGs
  • Change the default theme to indigo-pink
  • Create an NgModule per-component
  • Make all tests use one consistent testing module
  • Don't call createComponent synchronously after compileComponents
  • Change ComponentViewer from tab-group to nav-tabs
  • Simplify routes
  • A few misc visual tweaks

@tinayuangao tinayuangao left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jelbourn
jelbourn merged commit 7b53cfc into angular:master Jun 19, 2017
@Splaktar Splaktar mentioned this pull request Jul 10, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants