This repository was archived by the owner on Apr 4, 2025. It is now read-only.
Repository navigation
Conversation
…y default If there isn't any defaultProject set, permit to use the "root project" (ie the one which isn't in the `/projects/` folder) as the default project "by default" if it exists.
Test the feature introduced by 67a3d0e.
Contributor
|
Heya, I'm sorry but I don't think we should assume the default based on root. What you say does make sense, but I think that soft default trades some niche usage convenience (default when multiple projects are present) for some confusion (if things change folder they break). If this change were to go in, then it would need to be supported for quite a while. I can see this causing problems in the future and don't think the tradeoff is worth it. |
Contributor
Author
|
Thank you @filipesilva for this review. Didn't thought about this. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If there isn't any defaultProject set, permit to use the "root project" (ie the one which
isn't in the
/projects/folder) as the default project "by default" if it exists.In my opinion, if Angular CLI permit to create a project at workspace's root even if their is other projects in the
/projects/folder (especially as it does this by default when creating a new workspace), this "root project" should be, logically, the default project, as this is the one developers will look at first.