This repository was archived by the owner on Apr 4, 2025. It is now read-only.
Repository navigation
feat(@angular-devkit/build-optimizer): support webpack side effects flag - #531
Merged
Merged
Conversation
filipesilva
suggested changes
Mar 19, 2018
filipesilva
left a comment
filipesilva
left a comment
Contributor
There was a problem hiding this comment.
We'll need to either add a defensive option here, or completely move the peer dep to Webpack 4 and remove the path regexes. The second option also makes it only work for Angular 6+ though.
Member
Author
|
Updated to now work on older versions of webpack and fallback to the whitelist. |
filipesilva
approved these changes
Mar 19, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.