Repository navigation
refactor: use lightweight token for CDK accordion - #19676
Merged
devversion merged 2 commits intoJun 18, 2020
Merged
devversion merged 2 commits into
devversion merged 2 commits into
Conversation
devversion
added
P2
googlebot
added
the
cla: yes
devversion
marked this pull request as ready for review
June 17, 2020 16:22
Contributor
|
Want to change this to the new development branch? |
devversion
force-pushed
the
wip/light-weight-tokens-7
branch
from
June 18, 2020 10:53
aa49222 to
5db69b7
Compare
devversion
changed the base branch from
master
to
lightweight-token-optimizations
June 18, 2020 10:53
This comment has been minimized.
This comment has been minimized.
googlebot
added
cla: no
The `CdkAccordionItem` currently always brings in the `CdkAccordion` class. This is not desired as an accordion item could be used outside of a `<cdk-accordion>`. In those cases, we do not want to retain the accordion class w/ metadata unnecessarily. This also affects the `MatExpansionPanel` as it extends from the `CdkAccordionItem` and therefore always brings in the `CdkAccordion` list unnecessarily right now. Related to angular#19576.
devversion
force-pushed
the
wip/light-weight-tokens-7
branch
from
June 18, 2020 10:54
5db69b7 to
617ce7d
Compare
|
CLAs look good, thanks! ℹ️ Googlers: Go here for more info. |
googlebot
added
cla: yes
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
CdkAccordionItemcurrently always brings in theCdkAccordionclass. This is not desired as an accordion item could be used
outside of a
<cdk-accordion>. In those cases, we do not wantto retain the accordion class w/ metadata unnecessarily.
This also affects the
MatExpansionPanelas it extendsfrom the
CdkAccordionItemand therefore always brings inthe
CdkAccordionlist unnecessarily right now.Related to #19576.