Skip to content

Button docs example differs from specification #9360

Closed

Description

@kiwikern

Bug, feature request, or proposal:

Docs bug

What is the expected behavior?

Per specification, FABs should have the accent color if no color attribute is given. Embedded example in the docs shows the Basic FAB in white.
Buttons example should look the same in stackblitz and the embedded docs version.

What is the current behavior?

  • On stackblitz: FAB button without a color attribute is in the accent color as specified.
    image
  • In docs: FAB button without a color attribute has no background. (Basic).
    image

Activity

  1. added
    P3An issue that is relevant to core functions, but does not impede progress. Important, but not urgent
    on Jan 12, 2018
  2. ravishivt commented on Jan 13, 2018

    @ravishivt

    Same issue for my local project. My fab buttons have no color attribute and in non-prod builds, the buttons are correctly styled with accent palette. But during angular-cli production builds, the fab buttons have no default color.

  3. devversion commented on Jan 13, 2018

    @devversion
    Member

    I'm looking into this. It looks like something in the production pipeline of the Angular CLI removes some necessary code (looks like the build-optimizer in combination with uglify)

    with build-optimizer disabled
    image

    _with build-optimizer enabled
    image

  4. added a commit that references this issue on Jan 13, 2018
    897062c
  5. added a commit that references this issue on Jan 13, 2018
    10804d1
  6. added a commit that references this issue on Jan 21, 2018
    f6bd3fb
  7. added 2 commits that reference this issue on Jan 23, 2018
    b3f8a42
    f6a59cd
  8. angular-automatic-lock-bot commented on Sep 8, 2019

    @angular-automatic-lock-bot

    This issue has been automatically locked due to inactivity.
    Please file a new issue if you are encountering a similar or related problem.

    Read more about our automatic conversation locking policy.

    This action has been performed automatically by a bot.

  9. locked and limited conversation to collaborators on Sep 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

P3An issue that is relevant to core functions, but does not impede progress. Important, but not urgent

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions