Skip to content
This repository was archived by the owner on Apr 12, 2024. It is now read-only.

Fix for issue #5587 where app is bootstrapped more than once - #5863

Closed
siddii wants to merge 3 commits into
angular:masterfrom
siddii:master
Closed

Fix for issue #5587 where app is bootstrapped more than once#5863
siddii wants to merge 3 commits into
angular:masterfrom
siddii:master

Conversation

@siddii

@siddii siddii commented Jan 17, 2014

Copy link
Copy Markdown
Contributor

PR for #5587

I am not sure where to write the test for this fix (may be e2e with html file loading build/angular.js?) .

Here is a plunkr showing that the fix works - http://plnkr.co/edit/xey09HDiX5jQmHKbgEVi?p=preview

@petebacondarwin

petebacondarwin commented Jan 27, 2014

Copy link
Copy Markdown
Contributor

This looks like the right fix to me but I can't think how to create a unit test for it.

@siddii

siddii commented Jan 28, 2014

Copy link
Copy Markdown
Contributor Author

@petebacondarwin - I give 👍 to merge this PR if its OK with you.

@tbosch tbosch modified the milestones: 1.2.12, 1.2.11, 1.2.13 Feb 3, 2014
@btford btford modified the milestones: 1.2.14, 1.2.13 Feb 15, 2014
@IgorMinar IgorMinar modified the milestones: 1.3.0-beta.1, 1.2.14 Mar 1, 2014
@btford btford modified the milestones: 1.3.0-beta.2, 1.3.0-beta.1 Mar 10, 2014
@tbosch tbosch modified the milestones: 1.3.0-beta.3, 1.3.0-beta.2 Mar 14, 2014
@petebacondarwin

petebacondarwin commented Mar 18, 2014

Copy link
Copy Markdown
Contributor

@siddii - thanks for this PR. I added an E2E test that actually fails without the fix and included a warning in the console if one attempts to load more than one copy of angular.

@spirographer

spirographer commented Mar 18, 2014

Copy link
Copy Markdown

@siddii @petebacondarwin great to see such a clean solution to this bug. I should start digging in the source myself at some point.

vojtajina pushed a commit that referenced this pull request Mar 21, 2014
@siddii @vojtajina
fix(angular.bootstrap): only allow angular to load once
0d60f8d 
This is hard to test as a unit-test, since it involves the actual loading
of angular, but it turns out that it is easy to test using a protractor
e2e test.

Closes #5863
Closes #5587
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

No reviews

Assignees

@petebacondarwin petebacondarwin

Labels

cla: yes

Projects

None yet

Milestone

1.3.0-beta.3

Development

Successfully merging this pull request may close these issues.

6 participants

@siddii @petebacondarwin @spirographer @IgorMinar @btford @tbosch