Directive template: "[ng-show] > [ng-if] > [ng-transclude]" throws exception. Bug? #7240

Activity

1. rodyhaddad commented on Apr 25, 2014

   

   rodyhaddad

   on Apr 25, 2014

   Contributor

   More actions

   Check this comment for a workaround.

   Here's your jsbin with the workaround: http://jsbin.com/pemadama/2/edit

   hmm, I find it odd that ng-show plays a role in this
2. Wizek commented on Apr 25, 2014

   

   Wizek

   on Apr 25, 2014

   Author

   More actions

   Thanks @rodyhaddad, that was helpful.

   I too have no idea why ng-show makes any difference.

   Do you think it makes sense to attach a failing unit-test-case to this issue as a pull request?
3. petebacondarwin commented on Apr 28, 2014

   

   petebacondarwin

   on Apr 28, 2014

   Contributor

   More actions

   So the reason that ng-show makes a difference is that it adds a directive between the top level "compile" node and the ng-if. You can see that any directive that gets in the way will cause this problem...

   See http://jsbin.com/pemadama/6/edit

   I think this is actually some kind of bug, since clearly the outer transclude is sort of available it is just not passed through when the compiler hits a directive that also creates a transclude. I feel that somehow we ought to have a stack of transclusion functions that directives can un-peel as we go down through the compilation....
4. petebacondarwin

   self-assigned this

   on Apr 28, 2014
5. petebacondarwin

   added this to the 1.3.0-beta.8 milestone on Apr 28, 2014
6. petebacondarwin

   added

   type: bug

   on Apr 28, 2014
7. petebacondarwin

   added 3 commits that reference this issue on May 7, 2014

   test($compile): nested transcludes not passing down tree

   ...

   7e56eda

   test($compile): top level nested transcludes are passing down tree

   ...

   5a5327c

   test($compile): top level nested transcludes are passing down tree

   ...

   7599625
8. caitp

   modified the milestones: 1.3.0-beta.9, 1.3.0-beta.8 on May 9, 2014
9. 13 remaining items

   Load more
10. IgorMinar

    added a commit that references this issue on May 16, 2014

    fix($compile): pass transcludeFn down to nested transclude directives

    ...

    This issue will close once commit 0d4d85f is merged into the 'master' branch.

    0d4d85f
11. vojtajina

    added a commit that references this issue on May 16, 2014

    fix($compile): pass transcludeFn down to nested transclude directives

    ...

    This issue will close once commit 1138506 is merged into the 'master' branch.

    1138506
12. vojtajina

    closed this as completedin 4f03dc5on May 16, 2014
13. petebacondarwin

    added a commit that references this issue on May 21, 2014

    fix($compile): pass transcludeFn down to nested transclude directives

    ...

    This issue will close once commit e84f7bc is merged into the 'master' branch.

    e84f7bc
14. rodyhaddad commented on May 21, 2014

    

    rodyhaddad

    on May 21, 2014

    Contributor

    More actions

    This should be re-opened as 4f03dc5 was reverted by e994259.
    Here's the original jsbin with the latest snapshot: http://jsbin.com/pemadama/12/edit
15. petebacondarwin

    added 3 commits that reference this issue on May 22, 2014

    fix($compile): pass transcludeFn down to nested transclude directives

    ...

    This issue will close once commit 7c98bb2 is merged into the 'master' branch.

    7c98bb2

    fix($compile): pass transcludeFn down to nested transclude directives

    ...

    This issue will close once commit e045b8b is merged into the 'master' branch.

    e045b8b

    fix($compile): pass transcludeFn down to nested transclude directives

    ...

    This issue will close once commit d48d129 is merged into the 'master' branch.

    d48d129
16. RichardLitt

    added a commit that references this issue on May 24, 2014

    fix($compile): pass transcludeFn down to nested transclude directives

    ...

    This issue will close once commit 0268069 is merged into the 'master' branch.

    0268069
17. vojtajina

    added 4 commits that reference this issue on May 28, 2014

    fix($compile): pass transcludeFn down to nested transclude directives

    ...

    This issue will close once commit 30ed428 is merged into the 'master' branch.

    30ed428

    fix($compile): pass transcludeFn down to nested transclude directives

    ...

    This issue will close once commit a4ac48f is merged into the 'master' branch.

    a4ac48f

    fix($compile): pass transcludeFn down to nested transclude directives

    ...

    This issue will close once commit 0641d76 is merged into the 'master' branch.

    0641d76

    fix($compile): pass transcludeFn down to nested transclude directives

    ...

    This issue will close once commit 1fef5fe is merged into the 'master' branch.

    1fef5fe
18. caitp

    added a commit that references this issue on Jun 13, 2014

    fix($compile): pass transcludeFn down to nested transclude directives

    ...

    This issue will close once commit 09bfbd5 is merged into the 'master' branch.

    09bfbd5
19. petebacondarwin

    added a commit that references this issue on Jun 13, 2014

    fix($compile): pass transcludeFn down to nested transclude directives

    ...

    This issue will close once commit 8df5f32 is merged into the 'master' branch.

    8df5f32