Skip to content
This repository was archived by the owner on Apr 12, 2024. It is now read-only.
This repository was archived by the owner on Apr 12, 2024. It is now read-only.

ng-animate with css transitions broken in Safari 5.1 and lower #6601

Closed

Description

@jamessharp

In angular 1.2.14 using css transitions with angular-animate seems to be broken in Safari 5.1. The transition doesn't fire and I get a requestAnimationFrame is not defined error in the console. It works fine in 1.2.13.

I've tracked this down to this line which fails if there is no requestAnimationFrame function present.

@matsko commented in #6535 that "All browsers that support CSS animations/transitions also support RAF, therefore, there is no reason to fallback to timeout anymore" but that doesn't seem to be the case in Safari 5.1 (and lower):

The fix is probably to check $$rAF.supported and use $timeout if not.

Activity

  1. mparisi76 commented on Mar 7, 2014

    @mparisi76

    I've also experienced this after updating to 1.2.14. Is the temporary solution to use version 1.2.13?

  2. szimek commented on Mar 13, 2014

    @szimek

    Got the same issue. Is Safari 5.1 officially supported by Angular 1.x?

  3. added this to the milestone on Mar 13, 2014
  4. IgorMinar commented on Mar 13, 2014

    @IgorMinar
    Contributor

    closing in favor of #6654

  5. IgorMinar commented on Mar 13, 2014

    @IgorMinar
    Contributor

    @szimek we don't officially support 5.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions