Skip to content

feat(@angular/cli): use architect - #9883

Merged
hansl merged 2 commits into
masterfrom
move-build-system
Mar 16, 2018
Merged

feat(@angular/cli): use architect#9883
hansl merged 2 commits into
masterfrom
move-build-system

Conversation

@filipesilva

@filipesilva filipesilva commented Mar 6, 2018 •
edited
Loading

Copy link
Copy Markdown
Contributor

Fix #9973

@filipesilva
filipesilva force-pushed the move-build-system branch 3 times, most recently from 27401e6 to ce7c8ed Compare March 6, 2018 19:02
@Brocco
Brocco force-pushed the move-build-system branch from ce7c8ed to 170bca6 Compare March 7, 2018 19:30
@googlebot

googlebot commented Mar 7, 2018

Copy link
Copy Markdown

So there's good news and bad news.

👍 The good news is that everyone that needs to sign a CLA (the pull request submitter and all commit authors) have done so. Everything is all good there.

😕 The bad news is that it appears that one or more commits were authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that here in the pull request.

Note to project maintainer: This is a terminal state, meaning the cla/google commit status will not change from this state. It's up to you to confirm consent of the commit author(s) and merge this pull request when appropriate.

@googlebot googlebot added cla: no and removed cla: yes labels Mar 7, 2018
@filipesilva
filipesilva force-pushed the move-build-system branch 10 times, most recently from 6a6183a to 26ff802 Compare March 15, 2018 11:45
@filipesilva
filipesilva force-pushed the move-build-system branch 11 times, most recently from 7ddcd53 to b02d6c4 Compare March 15, 2018 15:53
@filipesilva
filipesilva force-pushed the move-build-system branch 5 times, most recently from 9f57255 to af3f74a Compare March 15, 2018 20:30
hansl
hansl reviewed Mar 15, 2018
View reviewed changes
Comment thread packages/@angular/cli/commands/build.ts
export interface BuildTaskOptions extends BuildOptions {
statsJson?: boolean;
export interface Options {
app?: string;

@hansl hansl Mar 15, 2018

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

project?

@hansl hansl Mar 15, 2018

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need to be changed this week, but can be after this PR.

@filipesilva filipesilva mentioned this pull request Mar 16, 2018
Closed
hansl
hansl reviewed Mar 16, 2018
View reviewed changes
Comment thread packages/@angular/cli/commands/test.ts
app?: string;
preserveSymlinks?: boolean;
configuration?: string;
prod: boolean;

@hansl hansl Mar 16, 2018

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ng test --prod?

@hansl
hansl merged commit b75b21f into master Mar 16, 2018
@Brocco
Brocco deleted the move-build-system branch March 16, 2018 18:15
@joshwiens joshwiens mentioned this pull request Mar 31, 2018
Closed
@jakeNiemiec jakeNiemiec mentioned this pull request May 9, 2018
Closed
@angular-automatic-lock-bot

angular-automatic-lock-bot Bot commented Sep 12, 2019

Copy link
Copy Markdown

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot Bot locked and limited conversation to collaborators Sep 12, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer
@hansl hansl hansl approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

ng build --prod does NOT minify / uglify / remove comments using angular-cli 6 beta

3 participants

@filipesilva @googlebot @hansl