Repository navigation
feat(@angular/cli): Update command runner. - #9707
Conversation
327d9a1 to
e9c854d
Compare
94aeda4 to
2062349
Compare
ef7c146 to
bdf816a
Compare
7ab5470 to
c15a808
Compare
| `Error 418: As Awesome As Can Get.` | ||
| `Error 418: As Awesome As Can Get.`, | ||
| `I spy with my little eye a great developer!`, | ||
| `noop... already awesome.` |
| project: environment.project, | ||
| ui: this.ui, | ||
| }; | ||
| return runCommand(environment.commands, environment.cliArgs, logger, context) |
There was a problem hiding this comment.
Are we doing await/async in this PR?
There was a problem hiding this comment.
Yes, I can refactor, but I wanted it working first.
| // Attempt to find command in ember-cli core commands | ||
| let command = findCommand(commands, commandName); | ||
|
|
||
|
|
| } | ||
|
|
||
| validate(_options: any): boolean | Promise<boolean> { | ||
| return true; |
There was a problem hiding this comment.
It's a base implementation that can be overridden, but the runner relies on a boolean being returned. Not all commands will implement validate.
There was a problem hiding this comment.
Sorry I pointed to the wrong file. the Doc command still has an empty override.
|
|
||
| availableOptions: [ | ||
| export default class GetCommand extends Command { | ||
| public name = 'get'; |
There was a problem hiding this comment.
Won't hurt anything by adding it.
|
When this PR gets merged, this devkit PR should be merged too: angular/devkit#481 |
93d2afd to
b9df667
Compare
hansl
left a comment
hansl
left a comment
There was a problem hiding this comment.
LGTM. We can rework stuff with the TODOs in there. Cheers!
This change removes the dependency of the ember-cli command structure.
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
This change removes the dependency of the ember-cli command structure.