Skip to content

feat(@angular/cli): support includePaths for less (closes #7083) - #7212

Merged
filipesilva merged 2 commits into
angular:masterfrom
JPeer264:feat/less-paths
Aug 2, 2017
Merged

filipesilva merged 2 commits into
angular:masterfrom
JPeer264:feat/less-paths

Conversation

@JPeer264

Copy link
Copy Markdown
Contributor

This should solve #7083.

@googlebot

Copy link
Copy Markdown

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.


  • If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
  • If your company signed a CLA, they designated a Point of Contact who decides which employees are authorized to participate. You may need to contact the Point of Contact for your company and ask to be added to the group of authorized contributors. If you don't know who your Point of Contact is, direct the project maintainer to go/cla#troubleshoot.
  • In order to pass this check, please resolve this problem and have the pull request author add another comment and the bot will run again.

@JPeer264

Copy link
Copy Markdown
Contributor Author

I signed it!

@googlebot

Copy link
Copy Markdown

CLAs look good, thanks!

@filipesilva
filipesilva self-requested a review July 31, 2017 13:53
@filipesilva filipesilva self-assigned this Jul 31, 2017

@filipesilva filipesilva left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Clean change and test, LGTM!

@filipesilva filipesilva closed this Aug 2, 2017
@filipesilva filipesilva reopened this Aug 2, 2017
@filipesilva
filipesilva merged commit 2d7a6f2 into angular:master Aug 2, 2017
@JPeer264
JPeer264 deleted the feat/less-paths branch August 2, 2017 11:45
@PikaChokeMe

PikaChokeMe commented Mar 8, 2018 •

Copy link
Copy Markdown

Is this supposed to be working right this second?
I've tried adding

"styles": [
                "styles/colors.less",
                "styles/mixins.less",
                "../node_modules/quill/dist/quill.core.css",
                "../node_modules/quill/dist/quill.snow.css"
            ],
            "stylePreprocessorOptions": {
                "includePaths": [
                    "styles"
                ]
            },

To my project as well as having

| my-angular-app
 \ src
   \styles
    | mixins.less
    | colors.less

Where I have
@tablet-view: 1023px;

But after trying to use @tablet-view in one of my components.less files I end up with

ERROR in ./src/app/modules/my-module/components/some-page/my-page.component.less
Module build failed: 


        .respond-max(@tablet-view - 1; { order: 3; flex: 1 0 100%; });
                   ^
Variable @tablet-view is undefined
      in C:\Users\MyUser\Source\my-angular-app\src\app\modules\my-module\components\some-page\my-page.component.less (line 39, column 21)

Any advice or tips on why it might not be working?

@JPeer264

JPeer264 commented Mar 8, 2018

Copy link
Copy Markdown
Contributor Author

@BustyLoli-Chan have you put a @import 'filename' at the top of your file?

I assume that you have defined everything in mixins.less, then it should look like following:

@import 'mixins';

.respond-max(@tablet-view - 1; { order: 3; flex: 1 0 100%; });

@angular-automatic-lock-bot

Copy link
Copy Markdown

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot Bot locked and limited conversation to collaborators Sep 12, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants