Skip to content

fix(@angular/cli): add typing for module.id for SystemJS usage - #5193

Merged
hansl merged 1 commit into
angular:masterfrom
Brocco:module-id-fix
Mar 3, 2017
Merged

hansl merged 1 commit into
angular:masterfrom
Brocco:module-id-fix

Conversation

@Brocco

@Brocco Brocco commented Mar 3, 2017

Copy link
Copy Markdown
Contributor

No description provided.

@Brocco
Brocco requested a review from hansl March 3, 2017 02:05

@hansl hansl left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect! LGTM!

@hansl
hansl merged commit 21d776f into angular:master Mar 3, 2017
@johnpapa

johnpapa commented Mar 3, 2017

Copy link
Copy Markdown
Contributor

thanks, LGTM

@leolanese

Copy link
Copy Markdown

yep it works

@angular-automatic-lock-bot

Copy link
Copy Markdown

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot Bot locked and limited conversation to collaborators Sep 12, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants