Repository navigation
fix(@angular-devkit/build-optimizer): don't wrap classes which static… - #15201
Conversation
… properties have been removed At the moment the `wrap-enums` transfomers is being run prior to `scrub-file` and this is resulting classes which all static properties have been dropped to be wrapped in IIFE.
filipesilva
left a comment
There was a problem hiding this comment.
I'm not sure this is correct... some of the patterns we identify in other transformers might not be identified correctly after this.
Can you check on AIO please? If this change is fine then it's size might go down slightly. Also try on AIO after removing all lazy imports (like https://github.com/angular/angular/blob/master/aio/src/app/custom-elements/element-registry.ts) to force module concatenation to put all angular code in the same bundle.
|
|
Without lazy loading
|
|
Everything looks good then. Whatever necessity we had for ordering those transforms does not seem to apply anymore. @clydin can you think of any problem with the order? |
|
I guess #15314 is why we had the previous order? The scrub file transformer would scoop stuff in, and then the tslint helpers wouldn't get the pure comment. |
|
@filipesilva yes indeed |
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
… properties have been removed
At the moment the
wrap-enumstransfomers is being run prior toscrub-fileand this is resulting classes which all static properties have been dropped to be wrapped in IIFE.