Repository navigation
fix(@angular-devkit/build-angular): fix extractLicenses default - #12546
Merged
Merged
Conversation
clydin
requested changes
Oct 10, 2018
clydin
left a comment
clydin
left a comment
Member
There was a problem hiding this comment.
couldn't the default just be changed to false here: https://github.com/angular/angular-cli/blob/master/packages/angular_devkit/build_angular/src/browser/schema.json#L175 ?
filipesilva
force-pushed
the
licenses-prod-only
branch
from
October 10, 2018 14:17
b631314 to
7ac3320
Compare
filipesilva
changed the title
It should be false so that it doesn't affect dev builds. The default production config has it set to true already. Partially address angular#12432.
filipesilva
force-pushed
the
licenses-prod-only
branch
from
October 10, 2018 14:18
7ac3320 to
74060de
Compare
clydin
approved these changes
Oct 10, 2018
filipesilva
added
the
target: patch
vikerman
pushed a commit
that referenced
this pull request
Oct 11, 2018
It should be false so that it doesn't affect dev builds. The default production config has it set to true already. Partially address #12432.
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It should be false so that it doesn't affect dev builds. The default production config has it set to true already.
Partially address #12432.