Skip to content

Material theme broken with Build Optimizer. #9221

Closed

Description

@dinerotah

Versions

Angular CLI: 1.6.4
Node: 6.11.3
OS: win32 x64
Angular: 5.2.0
... animations, common, compiler, compiler-cli, core, forms
... language-service, platform-browser, platform-browser-dynamic
... router

@angular/cdk: 5.0.4
@angular/cli: 1.6.4
@angular/material: 5.0.4
@angular-devkit/build-optimizer: 0.0.37
@angular-devkit/core: 0.0.24
@angular-devkit/schematics: 0.0.45
@ngtools/json-schema: 1.1.0
@ngtools/webpack: 1.9.4
@schematics/angular: 0.1.12
typescript: 2.6.2
webpack: 3.10.0

Repro steps

Observed behavior

Running npm run start -- --prod produce a fab button wihtout accent color:

with bd

Running npm run start -- --prod --build-optimizer=false works fine:

without-bd

Desired behavior

Same behavior with/without Build Optimizer.

Mention any other details that might be useful (optional)

Activity

  1. dinerotah commented on Jan 15, 2018

    @dinerotah
    ContributorAuthor

    @filipesilva After digging around I found that uglifyCompressOptions.pure_getters = true was removing something that is useful. By removing https://github.com/angular/angular-cli/blob/master/packages/%40angular/cli/models/webpack-configs/production.ts#L131 everything works fine.

    This compression in my case decrease the vendor bundle size by 1.63%
    glifyCompressOptions.pure_getters = false

    image

    glifyCompressOptions.pure_getters = true

    image

  2. clydin commented on Jan 15, 2018

    @clydin
    Member

    Nice job on the research. This is actually being tracked over here: angular/devkit#388. And there's a pending PR against material to fix.

  3. Brocco commented on Jan 15, 2018

    @Brocco
    Contributor

    Closing as this is being tracked by the issue mentioned by @clydin above.

  4. alexjlockwood commented on Jan 21, 2018

    @alexjlockwood

    Could anyone recommend a workaround for this issue?

  5. angular-automatic-lock-bot commented on Sep 7, 2019

    @angular-automatic-lock-bot

    This issue has been automatically locked due to inactivity.
    Please file a new issue if you are encountering a similar or related problem.

    Read more about our automatic conversation locking policy.

    This action has been performed automatically by a bot.

  6. locked and limited conversation to collaborators on Sep 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions