TS2304: cannot find name "xxx"——after update to rc.0 #5046

Activity

1. sinedied commented on Feb 27, 2017

   

   sinedied

   on Feb 27, 2017

   Contributor

   More actions

   Same here, seems that it's due to changes with tsconfig*.json files.
2. sinedied commented on Feb 27, 2017

   

   sinedied

   on Feb 27, 2017

   Contributor

   More actions

   After getting some sweat, I found the workaround:

   The new tsconfig.json at the root is the culpirit, as it is it cannot compile the app files properly.

   Change it to this and it will work again:

   {
     "compileOnSave": false,
     "compilerOptions": {
       "outDir": "./dist/out-tsc",
       "sourceMap": true,
       "declaration": false,
       "moduleResolution": "node",
       "emitDecoratorMetadata": true,
       "experimentalDecorators": true,
       "lib": [
         "es2016",
         "dom"
       ],
       "target": "es5"
     }
   }

   It was missing the dom lib and a target to properly compile files.

   🎉React with 🎉7Reacted by Max Pfandl, Filipe Silva, Wayearn, Antony Budianto, Khaled Triek, Fabien Dehopré and Tristan Shi
3. cexbrayat commented on Feb 27, 2017

   

   cexbrayat

   on Feb 27, 2017

   Last edited by cexbrayat

   Member

   More actions

   tsconfig now work by inheritance, so tsconfig.app.json is the one used to compile the app, and does include the dom library, that why the CLI compilation is fine.

   On the other hand, IDEs are lost with so many files and use the one they find at the root, that's why you see warnings in your app when using the dom, or in your tests (there is now a dedicate tsconfig file for the tests).

   This was introduced by 69e6c71

   @filipesilva do you think that IDEs are ever gonna understand the separate tsconfig? Some IDEs don't allow to specify several ones, how will they get that the src files must be compiled with tsconfig.app.json and the tests with tsconfig.spec.json?
4. filipesilva commented on Feb 27, 2017

   

   filipesilva

   on Feb 27, 2017

   Contributor

   More actions

   @sinedied comment is spot on. I forgot to leave the dom lib there at the root. @deebloo's PR will fix it.

   @cexbrayat nope, don't think they'll even understand. IDEs will use the top-level one for everything so it will essentially but a mish-mash of all the common parts. It's unfortunate and I wish there was a better solution.

   As long we need two tsconfigs in the same folder (app/specs) I don't see a better alternative.
5. sinedied commented on Feb 27, 2017

   

   sinedied

   on Feb 27, 2017

   Contributor

   More actions

   @cexbrayat @filipesilva AFAIK, Webstorm (and other Jetbrains similar IDEs) use the most top-level tsconfig.json file it finds for a specified folder, so that's why it was working fine until the extra separation and renaming.

   Maybe the e2e/app config could be renamed to just tsconfig.json, while keeping the one for the spec like it is (and maybe removing the root tsconfig.json?) would be better so the IDE could catch the correct config (except for unit tests)?
6. filipesilva commented on Feb 27, 2017

   

   filipesilva

   on Feb 27, 2017

   Contributor

   More actions

   @sinedied in that case the IDE would still not catch the correct config for tests (like you said). You'd then have to fiddle with the app tsconfig until it covered both app and unit test files which would leave you were we were before.

   So if you have to compromise, it's better to compromise in a central place while making it obvious what each tsconfig does, and making them independent.
7. wayearn

   closed this as completedon Feb 28, 2017
8. deebloo

   added 3 commits that reference this issue on Feb 28, 2017

   fix(@angular/cli): add dom to lib array \n fixes angular#5046

   This issue will close once commit b304165 is merged into the 'master' branch.

   b304165

   fix(@angular/cli): add dom to lib array > fixes angular#5046

   This issue will close once commit 5d7deef is merged into the 'master' branch.

   5d7deef

   fix(@angular/cli): add dom to lib array

   ...

   This issue will close once commit c089d67 is merged into the 'master' branch.

   c089d67
9. sinedied commented on Feb 28, 2017

   

   sinedied

   on Feb 28, 2017

   Contributor

   More actions

   @deebloo I'm afraid just adding the dom library does not fix the issue, you also need to add the target property with a value >= es5 to fix the errors in Webstorm (and other IDEs I think).
10. deebloo

    added 2 commits that reference this issue on Feb 28, 2017

    fix(@angular/cli): add dom to lib array

    ...

    This issue will close once commit 19f3569 is merged into the 'master' branch.

    19f3569

    fix(@angular/cli): add dom to lib array

    ...

    This issue will close once commit e5de190 is merged into the 'master' branch.

    e5de190
11. filipesilva

    added a commit that references this issue on Feb 28, 2017

    fix(@angular/cli): add dom to lib array (#5060)

    ...

    This issue will close once commit dd9eb17 is merged into the 'main' branch.

    dd9eb17
12. asnowwolf

    added a commit that references this issue on Apr 12, 2017

    fix(@angular/cli): add dom to lib array (angular#5060)

    ...

    This issue will close once commit c8181b8 is merged into the 'master' branch.

    c8181b8
13. angular-automatic-lock-bot commented on Sep 6, 2019

    

    angular-automatic-lock-botbot

    on Sep 6, 2019

    More actions

    This issue has been automatically locked due to inactivity.
    Please file a new issue if you are encountering a similar or related problem.

    Read more about our automatic conversation locking policy.

    _{This action has been performed automatically by a bot.}
14. angular-automatic-lock-bot

    locked and limited conversation to collaborators on Sep 6, 2019
15. mostafaibr

    added a commit that references this issue on May 29, 2026

    fix(@angular/cli): add dom to lib array (angular#5060)

    ...

    This issue will close once commit 0806c1a is merged into the 'master' branch.

    0806c1a