Skip to content

Support npm linked libraries #1875

Closed

Description

@ert78gb

Please provide us with the following information:

  1. OS? Windows 7, 8 or 10. Linux (which distribution). Mac OSX (Yosemite? El Capitan?)
    El Capitan 10.11.6
  2. Versions. Please run ng --version. If there's nothing outputted, please run
    in a Terminal: node --version and paste the result here:
    Could not start watchman; falling back to NodeWatcher for file system events.
    Visit http://ember-cli.com/user-guide/#watchman for more info.
    angular-cli: 1.0.0-beta.11-webpack.2
    node: 6.3.1
    os: darwin x64
  3. Repro steps. Was this an app that wasn't created using the CLI? What change did you
    do on your code? etc.
  • checkout git repository
  • cd into directory
  • npm link
  • go to main project
  • npm install 'linked package'
  • ng build

If I commit the changes and npm install directly from github repo. everything is working

  1. The log given by the failure. Normally this include a stack trace and some
    more information.
    null pointer exception when loading RC5 module.
  2. Mention any other details that might be useful.
    https://webpack.github.io/docs/troubleshooting.html
  3. npm linked modules don’t find their dependencies

Thanks! We'll be in touch soon.

Activity

  1. ghidoz commented on Sep 4, 2016

    @ghidoz

    Same for me. The solution should be add these lines to the webpack config:

    module.exports = {
      resolve: { fallback: path.join(__dirname, "node_modules") },
      resolveLoader: { fallback: path.join(__dirname, "node_modules") }
    };
    

    But there is no webpack config that we can edit!

  2. filipesilva commented on Sep 22, 2016

    @filipesilva
    Contributor

    Would you be willing to submit a PR to add those options?

    @TheLarkInn can you have a look at this solution? It's the one listed in http://webpack.github.io/docs/troubleshooting.html#npm-linked-modules-doesn-t-find-their-dependencies

  3. serhiisol commented on Sep 22, 2016

    @serhiisol
    Contributor

    I've found solution for that and I'll make a pull request ;) hold on guys :)

    (#2291)

    @filipesilva, @TheLarkInn Could you guys take a look at my PR ? Thanks

  4. added a commit that references this issue on Oct 10, 2016
  5. added a commit that references this issue on Oct 14, 2016
  6. added a commit that references this issue on Oct 19, 2016
  7. added a commit that references this issue on Nov 3, 2016
  8. angular-automatic-lock-bot commented on Sep 6, 2019

    @angular-automatic-lock-bot

    This issue has been automatically locked due to inactivity.
    Please file a new issue if you are encountering a similar or related problem.

    Read more about our automatic conversation locking policy.

    This action has been performed automatically by a bot.

  9. locked and limited conversation to collaborators on Sep 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    needs: investigationRequires some digging to determine if action is needed

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions