Passing additional options to node-sass #1791

Activity

1. petomalina commented on Aug 23, 2016

   

   petomalina

   on Aug 23, 2016

   Author

   More actions

   I needed to customize webpack-build-development.ts file inside angular-cli so the library could be compiled correctly. Is there any way to do this by configuration in angular cli?

   https://www.diffchecker.com/05czn5se
2. filipesilva

   added

   command: build

   P5The team acknowledges the request but does not plan to address it, it remains open for discussionThe team acknowledges the request but does not plan to address it, it remains open for discussion

   feature: webpack

   on Aug 23, 2016
3. filipesilva commented on Aug 23, 2016

   

   filipesilva

   on Aug 23, 2016

   Contributor

   More actions

   There is no way to do this right now, but we're getting a few requests for ways to add paths so it's likely to make it in.

   👍React with 👍3Reacted by Thilak Rao, Jose E. Bolaños and Clay vanSchalkwijk
4. josenriq commented on Sep 27, 2016

   

   josenriq

   on Sep 27, 2016

   Last edited by josenriq

   More actions

   @gelidus Great hack. I wanted to do the same, but it doesn't seem to work.

   • Changed webpack-build-development.ts
   • Rebuilt the angular-cli project and ran npm link.
   • Installed npm install bootstrap-sass as well, as that seems to be the path you referred to here https://www.diffchecker.com/05czn5se

   Still getting the same errors for "bootstrap/*". Any suggestions are greatly appreciated.
5. vmasek commented on Sep 29, 2016

   

   vmasek

   on Sep 29, 2016

   More actions

   @linktothapast
   I've written a workaround that works with angular-cli 1.0.0-beta.15, for 1.0.0-beta.11-webpack.2 just locate right files and adjust the script.

   http://stackoverflow.com/questions/39635971/angular-cli-configure-sass-loader-to-include-node-modules-in-includepath/39726440#39726440

   👍React with 👍1Reacted by Jose E. Bolaños
6. filipesilva

   self-assigned this

   on Dec 9, 2016
7. hansl commented on Dec 21, 2016

   

   hansl

   on Dec 21, 2016

   Contributor

   More actions

   Closing this as obsolete. We support this.

   👍React with 👍1Reacted by Peter Malina
8. hansl

   closed this as completedon Dec 21, 2016
9. filipesilva commented on Dec 30, 2016

   

   filipesilva

   on Dec 30, 2016

   Contributor

   More actions

   @hansl we don't yet support it, work is ongoing in #2747. Its on my shortlist of stuff to look at and get sorted.

   👍React with 👍1Reacted by Jared Armstrong
10. filipesilva

    reopened this on Dec 30, 2016
11. armstrjare commented on Jan 11, 2017

    

    armstrjare

    on Jan 11, 2017

    More actions

    FYI for those looking for a temporary workaround on this, I've found one that works with SASS. The SASS compiler uses a SASS_PATH env variable, so if you set that then everything seems to work swell. You just need to make sure the env var is set when you run any ng commands.

    In my project root directory, I have:

    # env.rc
    export SASS_PATH="`pwd`/src/css"
    

    And in my package.json:

    {
      "scripts": {
         "start": "source ./env.rc && ng serve"
         ...
       }
    }
    
12. filipesilva

    added 2 commits that reference this issue on Jan 13, 2017

    feat(build): add style paths

    ...

    This issue will close once commit e8a741d is merged into the 'master' branch.

    e8a741d

    feat(build): add style paths

    ...

    This issue will close once commit 4476f61 is merged into the 'master' branch.

    4476f61
13. 2 remaining items

    Load more
14. filipesilva

    added 4 commits that reference this issue on Jan 13, 2017

    feat(build): add style paths

    ...

    This issue will close once commit bdd4b36 is merged into the 'master' branch.

    bdd4b36

    feat(build): add style paths

    ...

    This issue will close once commit 28c1a23 is merged into the 'master' branch.

    28c1a23

    feat(build): add style paths

    ...

    This issue will close once commit c181c0c is merged into the 'master' branch.

    c181c0c

    feat(build): add style paths

    ...

    This issue will close once commit f1cd870 is merged into the 'master' branch.

    f1cd870
15. filipesilva

    closed this as completedin #4003on Jan 19, 2017
16. filipesilva

    added a commit that references this issue on Jan 19, 2017

    feat(build): add style paths (#4003)

    ...

    This issue will close once commit e5ef996 is merged into the 'main' branch.

    e5ef996
17. MRHarrison

    added a commit that references this issue on Feb 9, 2017

    feat(build): add style paths (angular#4003)

    ...

    This issue will close once commit 3ec5396 is merged into the 'master' branch.

    3ec5396
18. jpzwarte commented on Feb 24, 2017

    

    jpzwarte

    on Feb 24, 2017

    More actions

    Why limit this to just includePaths? I want to use the node-sass data option (https://github.com/sass/node-sass#data) to automatically include a setup stylesheet for all components:

    data: '@import \'variables\';'
    

    This way, you don't have to include the variables stylesheet in every component stylesheet where you want to use global variables.

    Please change additionalProperties to true?. cc @filipesilva

    👍React with 👍3Reacted by Frank Spin, David LOIRET and Nitsan Baleli
19. Ennas commented on Jun 26, 2017

    

    Ennas

    on Jun 26, 2017

    More actions

    Is this fix (i.e using stylePreprocessorOptions) available for LESS?

    👍React with 👍1Reacted by SixQ
20. filipesilva commented on Jun 28, 2017

    

    filipesilva

    on Jun 28, 2017

    Contributor

    More actions

    @jpzwarte we're not looking at adding all the configuration options each preprocessor supports, it would be practically unmaintainable. This one was a highly demanded one so it was added.

    @Ennas no, LESS did not support it at the time AFAIK.
21. jpzwarte commented on Jun 28, 2017

    

    jpzwarte

    on Jun 28, 2017

    More actions

    @filipesilva i understand :) It's just that having a "setup" stylesheet with SASS variables & mixins and not having to @import that everywhere seems like something that adds value for everyone :)

    👍React with 👍13Reacted by Boris Berman, Rafael Bitencourt, Matthew Dangerfield, Charlie McKenzie, Rafael Kraut, David LOIRET, ChrisLang, Hetty de Vries, msosa, John Palit and 3 more
22. spikyjt commented on May 10, 2018

    

    spikyjt

    on May 10, 2018

    More actions

    @filipesilva I'm not quite sure why we can't just pass through any options that preprocessors support, rather than having to "support" them? I can see from the way that you have implemented this option, that it would be unmaintainable to have to set them all up in webpack-build-styles.ts. However, there is also much demand for the data option, see #1253 #3700 and comments on https://netbasal.com/angular-cli-and-global-sass-variables-a1b92d8ca9b7 to mention a few.

    Since the data property would just be passed through as is, would adding it be a big job?

    👍React with 👍3Reacted by David Mulder, Vers and Alexis Georges
23. angular-automatic-lock-bot commented on Sep 8, 2019

    

    angular-automatic-lock-botbot

    on Sep 8, 2019

    More actions

    This issue has been automatically locked due to inactivity.
    Please file a new issue if you are encountering a similar or related problem.

    Read more about our automatic conversation locking policy.

    _{This action has been performed automatically by a bot.}
24. angular-automatic-lock-bot

    locked and limited conversation to collaborators on Sep 8, 2019
25. mostafaibr

    added a commit that references this issue on May 29, 2026

    feat(build): add style paths (angular#4003)

    ...

    This issue will close once commit 319d066 is merged into the 'master' branch.

    319d066