Repository navigation
Remove gate artifacts and publish coordinator updates - #8
Merged
Merged
Conversation
There was a problem hiding this comment.
🔵 Needs a closer look
It introduces sweeping, security- and correctness-critical changes (schema v6 validation, filesystem fingerprinting/locking, and recovery semantics) that warrant careful human review beyond automated checks.
Pull request overview
This PR publishes a major Coordinator state/protocol update (schema v6) and removes obsolete gate-related ignore behavior, along with adding a Docker-based demo harness and updated public contracts to document and enforce the new invariants.
Changes:
- Upgrades workflow state storage/validation to schema v6 (assessment + refinement/splitting, provenance obligations, scope fingerprinting, revised locking/recovery, and updated CLI commands).
- Updates the public protocol/docs and tests to reflect the new “fixed-point planning → route → claim → evidence” contract and removal of VCS coupling.
- Adds a Docker Compose demo runner plus supporting prompt/analysis content, and starts ignoring generated
/data/.
File summaries
| File | Description |
|---|---|
| tests/test_contract.py | Extends contract tests to assert new protocol references, compose invariants, and removal of git fields. |
| src/coordinator/state/store.py | Implements schema v6 state model, validation, planning gates, scope fingerprinting, locking, and updated mutation/CLI behaviors. |
| src/coordinator/cli/state.py | Updates CLI surface for schema v6 (new node fields, new commands, revised status choices). |
| skill/SKILL.md | Updates the controller protocol documentation for schema v6 workflows and execution rules. |
| skill/references/workflow-protocol.md | Refreshes the workflow protocol reference to match fixed-point planning and execution semantics. |
| skill/references/state-schema.md | Documents schema v6 structure, invariants, diagnostics, and evidence model. |
| skill/references/model-routing.md | Updates routing guidance to use schema v6 assessment mapping and explicit routing rules. |
| skill/references/complexity-accounting.md | Adds rubric v2 details plus refine/split contract examples and rules. |
| README.md | Updates high-level project claims to match schema v6 evidence and planning gates; adds demo guidance. |
| prompt.md | Adds the demo prompt used by the Compose-based run. |
| compose.yaml | Adds a reproducible demo harness for running Coordinator + generated backend in containers. |
| ANALYZES.md | Adds a detailed postmortem/analysis describing the demo failure mode and the schema v6 repair. |
| .gitignore | Drops obsolete /GATES.md ignore and ignores /data/ demo output. |
Review details
- Files reviewed: 11/14 changed files
- Comments generated: 1
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Comment on lines
+69
to
+70
| planning conventions. Use `node-refine --node-id ... | ||
| (--refinement-json|--refinement-file)` to atomically persist clarified or reassessed inputs. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
GATES.md; the branch tree contains noGATES.md,./gates, or related referencesValidation
ruff check --no-cache src skill/scripts testspython -m unittest discover -s tests -v(67 tests)python -m compileall -q src skill/scripts testsdocker compose config -q