Repository navigation
Integrate coordinator updates and localized READMEs - #10
Merged
Merged
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
There was a problem hiding this comment.
🟡 Changes recommended
next_action() returns required fields that omit node_id for actions whose commands need it, making the API contract ambiguous for callers that rely on next.
Once you've addressed the issues Copilot identified, you can request another Copilot review.
Pull request overview
This PR expands the coordinator’s high-level workflow lifecycle (atomic plan application, automatic routing, claim/start/complete, and next-action guidance), tightens structured JSON input handling, and updates documentation/tests accordingly, alongside adding localized README translations.
Changes:
- Add new state-owner commands and state-machine transitions:
plan-apply,node-route-auto,node-claim,node-start,node-complete,workflow-complete, and read-onlynext. - Harden JSON/command input parsing (duplicate keys, non-standard numeric constants, and size bounds) in both state and routing CLIs.
- Add README translations (pt-BR, es, zh-CN) and cross-link all README language variants; update skill protocol documentation to the new command path.
File summaries
| File | Description |
|---|---|
| tests/test_state.py | Adds coverage for plan-apply atomicity, stage validation, next-action selection, and full lifecycle commands. |
| tests/test_routing.py | Adds regression tests for strict JSON parsing (duplicate keys/constants) and oversized routing inputs. |
| tests/test_contract.py | Enforces CLI contract presence for new high-level orchestration commands and docs mentions. |
| src/coordinator/state/store.py | Implements plan-apply, node-route-auto, claim/start/complete lifecycle, workflow-complete, next_action oracle, and stricter decoding/bounded inputs. |
| src/coordinator/cli/state.py | Exposes new state CLI subcommands and validates --stage against supported stages. |
| src/coordinator/cli/routing.py | Adds bounded, strict JSON parsing for routing CLI inputs. |
| skill/SKILL.md | Updates operator protocol to prefer plan-apply/next/node-route-auto/.../workflow-complete and documents review convergence. |
| skill/references/workflow-protocol.md | Aligns the workflow protocol reference with the new lifecycle commands and next-action oracle. |
| skill/references/state-schema.md | Updates schema guidance to prefer node-route-auto and recognizes read-only next. |
| skill/references/model-routing.md | Updates routing reference to emphasize node-route-auto over manual node-route. |
| skill/references/complexity-accounting.md | Aligns complexity lifecycle guidance with node-route-auto and retry behavior. |
| skill/README.md | Updates skill entry-point docs and links to translated project READMEs. |
| README.md | Adds language links and documents the durable command path including next and workflow-complete. |
| README.es.md | Adds Spanish README translation and links. |
| README.pt-BR.md | Adds Brazilian Portuguese README translation and links. |
| README.zh-CN.md | Adds Simplified Chinese README translation and links. |
Review details
Suppressed comments (1)
src/coordinator/state/store.py:3316
next_action()returnscommand="node-update"for thestartaction, butrequiredomitsnode_ideven though the command needs--node-id(andnode_idsmay list multiple nodes). Includenode_idinrequiredso callers can build a complete invocation consistently.
"start",
"bound work must transition to running",
command="node-update",
node_ids=bound,
required=["status=running"],
- Files reviewed: 16/16 changed files
- Comments generated: 1
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Comment on lines
+3299
to
+3303
| "spawn_and_start", | ||
| "claimed work must be delegated and bound before execution", | ||
| command="node-start", | ||
| node_ids=claimed, | ||
| required=["child_id"], |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Validation
python3 -m unittest discover -s tests(85 tests passed)git diff --check