Skip to content

🧹 [code health improvement] Refactor CSimulator to use BNGLogger and BNGSimulatorError - #92

Closed
akutuva21 wants to merge 2 commits into
mainfrom
fix-csimulator-logging-15760036088045385340
Closed

akutuva21 wants to merge 2 commits into
mainfrom
fix-csimulator-logging-15760036088045385340

Conversation

@akutuva21

Copy link
Copy Markdown
Owner

Replaced assert statements and print statements in csimulator.py with the standard BNGLogger logging framework and explicit exception raising (BNGSimulatorError). This improves error visibility, structure, and avoids uninformative AssertionError crashes during simulations.


PR created automatically by Jules for task 15760036088045385340 started by @akutuva21

…rror

Co-authored-by: akutuva21 <44119804+akutuva21@users.noreply.github.com>
@google-labs-jules

Copy link
Copy Markdown

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

@akutuva21

Copy link
Copy Markdown
Owner Author

Superseded by #94 csimulator assert->BNGError transition.

@akutuva21 akutuva21 closed this Apr 13, 2026
@google-labs-jules

Copy link
Copy Markdown

Superseded by #94 csimulator assert->BNGError transition.

Understood. Acknowledging that this work is now superseded by #94 and stopping work on this task.

@akutuva21
akutuva21 deleted the fix-csimulator-logging-15760036088045385340 branch April 13, 2026 14:42
akutuva21 pushed a commit that referenced this pull request Jun 1, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant