Skip to content

Fix nbopen standard output and error handling in notebook generation - #89

Merged
akutuva21 merged 2 commits into
mainfrom
fix-nbopen-stdout-stderr-4118980527979395642
Apr 13, 2026
Merged

akutuva21 merged 2 commits into
mainfrom
fix-nbopen-stdout-stderr-4118980527979395642

Conversation

@akutuva21

Copy link
Copy Markdown
Owner

This commit resolves the TODO comment in bionetgen/core/main.py regarding standard output and error handling for the nbopen command. It correctly retrieves the streams from the app.config (with robust error fallback using AttributeError and KeyError), replacing the custom run_command (which didn't easily support arbitrary output destinations) with a subprocess.Popen.wait() combination that achieves correct behavior while being robust to invalid config values.


PR created automatically by Jules for task 4118980527979395642 started by @akutuva21

Co-authored-by: akutuva21 <44119804+akutuva21@users.noreply.github.com>
@google-labs-jules

Copy link
Copy Markdown

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

@akutuva21
akutuva21 merged commit 5e4fbe4 into main Apr 13, 2026
13 of 18 checks passed
@akutuva21
akutuva21 deleted the fix-nbopen-stdout-stderr-4118980527979395642 branch April 13, 2026 14:34
akutuva21 pushed a commit that referenced this pull request Jun 1, 2026
…kslashes

Strip stray unquoted backslashes in action normalization
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant