Skip to content

🧪 [testing improvement] Add tests for modelapi runner logic - #75

Closed
akutuva21 wants to merge 4 commits into
mainfrom
add-runner-tests-12788812618687811854
Closed

akutuva21 wants to merge 4 commits into
mainfrom
add-runner-tests-12788812618687811854

Conversation

@akutuva21

Copy link
Copy Markdown
Owner

🎯 What: The run convenience wrapper in bionetgen/modelapi/runner.py lacked explicit testing.
📊 Coverage: Created tests/test_runner.py which mocks BNGCLI and TemporaryDirectory to test scenarios where out=None (temp directory fallback) and when out is provided. Added testing to explicitly confirm error propagation and path restoration on execution failures.
✨ Result: Improved test coverage around library-mode runner operations, ensuring CLI invocation defaults and error handling behave as expected without requiring actual filesystem or binary executions in unit test environments.


PR created automatically by Jules for task 12788812618687811854 started by @akutuva21

Co-authored-by: akutuva21 <44119804+akutuva21@users.noreply.github.com>
@google-labs-jules

Copy link
Copy Markdown

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

google-labs-jules Bot and others added 3 commits April 13, 2026 14:07
Co-authored-by: akutuva21 <44119804+akutuva21@users.noreply.github.com>
Co-authored-by: akutuva21 <44119804+akutuva21@users.noreply.github.com>
@akutuva21

Copy link
Copy Markdown
Owner Author

Superseded by merged #102 runner tests.

@akutuva21 akutuva21 closed this Apr 13, 2026
@google-labs-jules

Copy link
Copy Markdown

Superseded by merged #102 runner tests.

Understood. Acknowledging that this work is now obsolete and stopping work on this task.

@akutuva21
akutuva21 deleted the add-runner-tests-12788812618687811854 branch April 13, 2026 14:46
akutuva21 pushed a commit that referenced this pull request Jun 1, 2026
Drop distutils for Python 3.12 compatibility (closes #58)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant