Skip to content

🧹 Bolt: Replace assert statements with BNGSimulatorError in csimulator - #57

Closed
akutuva21 wants to merge 3 commits into
mainfrom
bolt-bngerror-csimulator-6233764973034024898
Closed

akutuva21 wants to merge 3 commits into
mainfrom
bolt-bngerror-csimulator-6233764973034024898

Conversation

@akutuva21

Copy link
Copy Markdown
Owner

🧹 Bolt: Replace assert statements with structured BNGErrors

What:
Replaced generic assert statements in bionetgen/simulator/csimulator.py with structured BNGSimulatorError (a subclass of BNGError) and standardized error logging via BNGLogger. Also added BNGSimulatorError to bionetgen.core.exc.

Why:
To transition from generic assertions to specific custom exception classes for better error handling, traceability, and logging as part of an ongoing project convention update. This prevents application crashes with uninformative AssertionErrors.

Verification:
I manually verified the error raising mechanism through mock objects, ensuring that when unequal array lengths are supplied, the code successfully raises a BNGSimulatorError and logs the message appropriately. Tests were run, and any pre-existing environment-related failures were unchanged.

Result:
Safer error checking and logging implemented for simulation parameter setups.


PR created automatically by Jules for task 6233764973034024898 started by @akutuva21

Co-authored-by: akutuva21 <44119804+akutuva21@users.noreply.github.com>
@google-labs-jules

Copy link
Copy Markdown

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

@akutuva21

Copy link
Copy Markdown
Owner Author

Superseded by #94 csimulator assert->BNGError transition.

@akutuva21 akutuva21 closed this Apr 13, 2026
@google-labs-jules

Copy link
Copy Markdown

Superseded by #94 csimulator assert->BNGError transition.

Understood. Acknowledging that this work is now obsolete and stopping work on this task.

@akutuva21
akutuva21 deleted the bolt-bngerror-csimulator-6233764973034024898 branch April 13, 2026 14:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant