Skip to content

⚡ Bolt: Optimize balanceTranslator membership check #21

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
akutuva21 wants to merge 4 commits into from
Closed

⚡ Bolt: Optimize balanceTranslator membership check #21

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
c04bccf
Optimize membership checks inside `balanceTranslator` with sets
google-labs-jules[bot] Apr 9, 2026
110d65d
Optimize membership checks inside `balanceTranslator` with sets
google-labs-jules[bot] Apr 9, 2026
8664afd
Optimize membership checks inside `balanceTranslator` with sets
google-labs-jules[bot] Apr 9, 2026
34e56a4
chore: PR #21 remove forbidden artifacts and run black
akutuva21 Apr 13, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions .gitignore
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,3 +10,5 @@ temp_testing/*
build
dist
Issues/rule_keywords/test_DeleteMolecules_changed.bngl
.jules/
__pycache__/
12 changes: 4 additions & 8 deletions bionetgen/atomizer/writer/bnglWriter.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -116,17 +116,13 @@ def balanceTranslator(reactant, product, translator):
for rMolecule in rMolecules:
for pMolecule in pMolecules:
if rMolecule.name == pMolecule.name:
p_names = {y.name for y in pMolecule.components}
r_names = {y.name for y in rMolecule.components}
overFlowingComponents = [
x
for x in rMolecule.components
if x.name not in [y.name for y in pMolecule.components]
x for x in rMolecule.components if x.name not in p_names
]
overFlowingComponents.extend(
[
x
for x in pMolecule.components
if x.name not in [y.name for y in rMolecule.components]
]
[x for x in pMolecule.components if x.name not in r_names]
)
rMolecule.removeComponents(overFlowingComponents)
pMolecule.removeComponents(overFlowingComponents)
Expand Down
Loading