Repository navigation
Support eslint-plugin-react-hooks@2 - #2090
Conversation
|
@perrin4869 Hi! I don't suppose you could rebase on |
|
@edmorley just rebased! no problems there |
edmorley
left a comment
edmorley
left a comment
There was a problem hiding this comment.
@perrin4869 Thank you for the rebase! Travis is failing at the moment, but I believe should succeed after the change below? :-)
| - node_js: "6" | ||
| env: TEST=true ESLINT=5 REACT_HOOKS=1.7 PACKAGE=eslint-config-airbnb | ||
| exclude: | ||
| allow_failures: |
There was a problem hiding this comment.
I think the two new PREPUBLISH entries under include need equivalent entries under allow_failures here (since currently those runs are failing). eg:
- env: PREPUBLISH=true ESLINT=6 REACT_HOOKS=1.7 PACKAGE=eslint-config-airbnb
- env: PREPUBLISH=true ESLINT=5 REACT_HOOKS=1.7 PACKAGE=eslint-config-airbnb
There was a problem hiding this comment.
They don't; they're failing by design on master since new eslint rules have been released that haven't yet been added to the config. I'll rebase your PR after I've fixed it, you don't have to worry about it.
|
Hello, happy Monday! what's the status of this PR? Anything I can do to help drive it forward? |
Since #2083 was closed, I followed up, according to the changes requested there