Repository navigation
refactor(tool): remove the built-in todo tooling (#182) #183
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
cdbd1b4
refactor(tool): remove the built-in todo tooling (#182)
byapparov 783bc09
test(cli): fail clearly when the legacy-todo fixture finds no session…
byapparov d5257e9
test(flag): cover HeadlessRun directly now that todo gating is gone (…
byapparov f89f735
test: keep the legacy-todo tests independent of the todo table (#182 …
byapparov 5ae259f
test(storage): expect one fewer migration error without todo files (#…
byapparov File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file was deleted.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,3 +1,3 @@ | ||
| export { ControlAccountTable } from "../control/control.sql" | ||
| export { SessionTable, MessageTable, PartTable, TodoTable, PermissionTable } from "../session/session.sql" | ||
| export { SessionTable, MessageTable, PartTable, PermissionTable } from "../session/session.sql" | ||
| export { ProjectTable } from "../project/project.sql" |
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🟠 TodoTable removed from schema with no DROP migration.
🤖 Fix with your agent
Why this matters
TodoTable was deleted from the drizzle schema (and its re-export in src/storage/schema.ts) but no DROP TABLE migration was added: drizzle.config.ts drives drizzle-kit from "./src/**/.sql.ts", so with packages/cli/migration/ still containing CREATE TABLE todo,
bun script/check-migrations.ts(drizzle-kit check) deterministically exits 1 with "Schema has changes not captured in migrations!". The PR's own tests prove the table must keep existing (test/storage/json-migration.test.ts assertsSELECT count(*) FROM todoon a DB replayed from migration/*.sql; test/cli/run-continue-legacy-todo.test.ts raw-INSERTs into todo). Worse, the nextdrizzle-kit generatefor any unrelated change will emit DROP TABLE todo, which breaks both legacy-todo tests on fresh databases and silently deletes legacy todo rows from existing user DBs. CI wiring of check-migrations could not be verified, but the gate script fails locally regardless and the poisoned-generate consequence holds either way.