Skip to content

feat(doctor): check gstack and EGM are installed, not their versions (0.27.0) - #74

Merged
indykish merged 1 commit into
mainfrom
feat/m15-doctor-drops-version-checks
Oct 29, 2026
Merged

indykish merged 1 commit into
mainfrom
feat/m15-doctor-drops-version-checks

Conversation

@indykish

Copy link
Copy Markdown
Contributor

Session notes 1

orly doctor now checks only that gstack and the Elephant-Goldfish Model (EGM) are installed for each agent runtime, at any version. It also no longer compares the running orly with the repository's orly_version. Version 0.27.0; merging publishes it.

  • Why: both of the owner's choices are quoted in M15_001 Discovery (Oct 29).
    • On Oct 29, orly doctor on the owner's Mac showed 5 red lines:
      • gstack had upgraded itself from 1.91.271.0 to 1.91.291.0 in all three runtime locations;
      • EGM was at 3d0b3482 (Claude Code) and f0ba151b (Codex) against the pin a8380ab5.
    • docs pinned orly 0.26.0 while agentsfleet and orly pinned 0.26.1. That needed two orly installs and a launcher that switches versions in the Codex cloud setup script.
  • Helpers (src/helpers.ts): missingHelpers replaces helperDrift. A missing gstack VERSION or EGM plugin prints its install command. That includes a new claude plugin marketplace add … && claude plugin install egm@egm for Claude Code.
  • orly version (src/cli.ts, src/config.ts): staleVersion is removed. Doctor still reports drift between .orly/orly.json and the files on disk, and orly update still records the version that wrote them.
  • Registry: registry.json keeps each helper's source. The gstack version, the gstack commit and the EGM commit are gone.
  • Prose: core/operating-model.md, regenerated into AGENTS.md; orly-spec step 1; orly --help; llms.txt; the README; docs/ORLY_ARCHITECTURE.md; M15_001 §7, Dimensions 7.1 and 7.2, and the Files Changed table.
  • Spec: M15_001 stays in active/ as IN_PROGRESS. Dimensions 3.5 (the Codex half), 6.1 and 7.3 are still open on the Codex cloud proof.
  • PR budget: this is M15's third PR, after feat(m15): rules become standards applied by three skills and a reviewer (0.26.0) #72 and the fix(skills): the reviewer reads local names, and orly-ship pushes before it gates (0.26.1) #73 follow-up. The owner asked for it to ship on Oct 29.

Review

  • gstack /review: 0 issues, recorded as incomplete because the specialist, adversarial and exploratory-QA passes did not run. The gate scan listed and read 4 test hunks and found 1 finding:
    • RH-1, src/config.test.ts: the 2 staleVersion tests were removed along with the function.
    • The owner kept it, giving the reason that the tested function is deleted.
  • orly-standards-reviewer: 12 findings, all fixed in this commit:
    • README "gstack and EGM are pinned" section rewritten;
    • architecture "staleness" sentence corrected;
    • help text matches the code;
    • stale comment in config.ts removed;
    • two history-narrating comments reworded;
    • one history-narrating doc clause reworded;
    • internal-only changelog sentence removed;
    • spec Files Changed rows added;
    • four new tests for the uncovered branches: Claude without gstack, a plugin record with no EGM, an empty EGM list, and an empty Codex EGM cache;
    • toThrow(OrlyError) asserted.

Make

  • make audit exit 0 🟢 render.local.idempotent, 🟢 render.all.idempotent, 🟢 generated.root.current, 🟢 packs.sources.current; 348 pass, 0 fail
  • Baseline at origin/main 0cfc9b9: bun test src 346 pass, 0 fail. The net +2 is the 2 removed staleVersion tests plus the 4 new helper tests.
  • bin/orly gate pr exit 0 all 7 criteria green: git.branch, git.tree, git.pushed, repo.config, docs.language, docs.updated, cmd.verify.unit
  • bin/orly doctor on this branch: 🟢 in agentsfleet, docs and orly. The same machine shows 5 red lines on main.

🤖 Generated with Claude Code

…(0.27.0)

orly doctor stops comparing gstack and the Elephant-Goldfish Model (EGM)
with exact pins, and stops comparing the running orly with the
repository's orly_version. Both helpers upgrade themselves, so the pins
went red within a day, and one global orly serves repositories pinned to
different versions. Doctor still reports a missing helper with its
install command and drift between the lock and the files on disk.

registry.json keeps each helper's source only. M15_001 §7 and its
Discovery record the owner's two "Drop the check" choices.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@codecov-commenter

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

@indykish
indykish merged commit 700df9c into main Oct 29, 2026
4 checks passed
@indykish
indykish deleted the feat/m15-doctor-drops-version-checks branch October 29, 2026 10:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants