Skip to content

docs: explain guarded downloads and reviewed HTTP egress - #235

Open
indykish wants to merge 4 commits into
mainfrom
chore/m235-ci-downloads-changelog
Open

indykish wants to merge 4 commits into
mainfrom
chore/m235-ci-downloads-changelog

Conversation

@indykish

@indykish indykish commented Oct 31, 2026 •

Copy link
Copy Markdown
Contributor

The fleet-tools reference omits reviewed HTTP egress modes and redirected job-log reads. Document the saved policy, three-hop/30-second GET limit, header removal and completeness notices. Both new capabilities remain marked coming soon.

Companion source: agentsfleet feature branch, checked at a83a4f957958d9985fd7419955ee8cf484633801.

Session notes 1

Added the HTTP settings and download reference, with defaults, package domains and allow-list bounds. Corrected existing browser-availability and Slack-delivery claims while checking the whole page against version 0.71.0.

The HTTP switches preserve sandbox access; existing allow entries retain their conditional sandbox effect. This documentation supplies no deployment or acceptance result.

Review

Scoped standards and native adversarial findings are fixed:

  • Medium, fleets/tools.mdx: distinguish reviewed hosts from enabled package domains, qualify optional content type, and narrow the sandbox guarantee to the two new HTTP switches.
  • Medium, fleets/tools.mdx: describe current browser-tool unavailability and possible final Slack-delivery failure.
  • Low, fleets/tools.mdx: state the 64-entry/255-character bounds and refresh source-checked metadata.
  • Low, changelog.mdx: add the customer-visible lead and keep the entry within its prose budget.

Make

  • Baseline 93901fe0df3a2ba215821dd265d707c4b1e5eece, isolated checkout: make test — exit 0; 25 tests, OK, documentation check passed.
  • orly doctor — exit 0; installed rules match.
  • orly gate work — exit 0; 25 tests, OK.
  • orly gate pr at b610427ea04dad678c3c7692a4257124796d3abb — exit 0; make lint exit 0, OpenAPI drift clean, build validation passed, no broken links found.
  • Gitleaks staged and branch scans — exit 0; no new suppressions.

RetriggerView in GreptileConfidence Score: 5/5

The documentation changes appear safe to merge.

Summary

Documents upcoming HTTP access settings and guarded downloads.

  • Fleet authors can review and save HTTP egress settings.
  • Bodyless GET downloads follow redirects within the saved policy.
  • The tool reference no longer promises every final answer reaches Slack.

No actionable issues were established.

Reviews (2) · Last reviewed commit: "docs(m235): distinguish HTTP switches fr..." · Reviewed by Greptile

Copy link
Copy Markdown
Contributor Author

@greptileai review this draft. This documents the proposed behavior in agentsfleet/agentsfleet#792; the changelog entry is marked coming soon.

@indykish
indykish marked this pull request as ready for review November 1, 2026 09:00

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant