You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
This repository was archived by the owner on Sep 6, 2021. It is now read-only.
Repository navigation
This repository was archived by the owner on Sep 6, 2021. It is now read-only.
[JS code hints] Prefer results that match case of the query string #3971
@dangoor, I apologize but I am going to have to withdraw from fixing this bug and assign it back to you. I tried to work my way through the string matching algorithm but I am having a difficult time understanding all the pieces, and I am concerned I would do more harm than good if I muck around with it.
Activity
njx commentedon Jun 3, 2013
Reviewed, to @dloverin. Please assign a priority. Thanks!
dangoor commentedon Aug 16, 2013
Assigning to myself, medium priority.
lkcampbell commentedon Oct 26, 2013
@dangoor, I submitted a fix and assigned this bug to myself. I assume (and hope) that you will be doing the review.
dangoor commentedon Oct 26, 2013
@lkcampbell I'll be happy to review! Timing-wise we'll likely need to land this next sprint, but I'll take a look.
lkcampbell commentedon Oct 29, 2013
I'm closing that previous PR. Going to try out a different approach this week.
lkcampbell commentedon Nov 3, 2013
@dangoor, I apologize but I am going to have to withdraw from fixing this bug and assign it back to you. I tried to work my way through the string matching algorithm but I am having a difficult time understanding all the pieces, and I am concerned I would do more harm than good if I muck around with it.
dangoor commentedon Nov 4, 2013
@lkcampbell Yeah, sorry about that... StringMatch is pretty much my fault. I wrote a blog post about it, but that doesn't reduce the complexity any.
It has lots of tests, so you don't really need to worry about doing harm. But, I totally understand not wanting to unravel what that code does.
peterflynn commentedon Apr 11, 2014
Reviewed - agree with 1.0
13 remaining items
dangoor commentedon Oct 21, 2014
This is now fixed on master. woohoo!
FBNC to @iwehrman
marcelgerber commentedon Oct 21, 2014
Finally!
marcelgerber commentedon Oct 21, 2014
Btw, #3263 is a dupe of this issue that can be closed as well.
le717 commentedon Oct 21, 2014