Repository navigation
The Corretto distribution fails to find existing versions when using a task cache #474
Description
Description:
When using self-hosted runners on GHES with a tool cache, setup-java fails to find the cached version of the corretto distribution. This is due to Corretto using non-semver version numbers, e.g. for Java 17 the version is 17.0.6.10.1
Task version:
3.3 and greater
Platform:
- Ubuntu
- macOS
- Windows
Runner type:
- Hosted
- Self-hosted
Repro steps:
To repro, build a task cache with a given version of Java, e.g.:
- name: Setup Java
uses: actions/setup-java@v3
with:
distribution: 'corretto'
java-version: '17'Once the task cache has been build, run a job with the above step that uses the task cache. When you run the job setup-java will fail to find the cached version and and attempt to reach out to the internet. In our case this is blocked by a firewall rule.
To show that this is indeed an issue with the directory names on disk, the following can be done to make setup-java find it. In our case the Corretto Java version is 17.0.6.10.1:
- name: Fix Java Dir
run: mv /opt/hostedtoolcache/Java_Corretto_jdk/17.0.6.10.1 /opt/hostedtoolcache/Java_Corretto_jdk/17.0.6
- name: Setup Java
uses: actions/setup-java@v3
with:
distribution: 'corretto'
java-version: '17'The results of running this are as follows
Expected behavior:
The setup-java action should correctly find cached versions of Corretto on disk
Actual behavior:
The setup-java action fails to find cached versions of Corretto on disk and instead attempts to download a version from the internet.
Activity
IvanZosimov commentedon Mar 27, 2023
Hi, @jamestoyer 👋 ! Thanks for the issue, we will investigate it and get back to you with updates!
IvanZosimov commentedon Jul 7, 2023
Hi, @jamestoyer 👋 This PR should resolve the issue, it's already been merge into the main. So you can try how it works using:
The
mainbranch can be used only as a preview of the features that will be added to the next release as it may be not stable. As soon as the next release will be created, I'll ping you.emiksk commentedon Jul 20, 2023
@IvanZosimov
When the bug fix will be released?
I'm having trouble with the bug and hope it will be resolved in v3.
Thank you for your works!
IvanZosimov commentedon Jul 21, 2023
Hi, @emiksk 👋 Sorry for delays, it will be released very soon.
IvanZosimov commentedon Jul 24, 2023
Hi, @emiksk and @jamestoyer 👋 The new version of the setup-java is released. Please, check it out.
I'm going to close this issue, If you have any additions or questions feel free to ping us.