Skip to content

Default architecture to runner's architecture #375

Closed

Description

@cap10morgan

Description:
If the architecture param isn't set, it currently defaults to amd64/x64/x86-64/etc. It should instead default to the runner's architecture.

Justification:
Hopefully self-evident

Are you willing to submit a PR?
Yes, I have a proof-of-concept one ready to go for further discussion.

Activity

  1. panticmilos commented on Aug 29, 2022

    @panticmilos
    Contributor

    Hi @cap10morgan, thank you for submitting the report and creating PR for it. We will take a look :)

  2. self-assigned this
    on Aug 29, 2022
  3. tuckstarrydell commented on Sep 8, 2022

    @tuckstarrydell
  4. Fleshgrinder commented on Oct 7, 2022

    @Fleshgrinder

    I got tired and created a wrapping action: https://github.com/Fleshgrinder/setup-java

  5. cap10morgan commented on Oct 7, 2022

    @cap10morgan
    ContributorAuthor

    PR #376 is hopefully being merged soon so this will be implemented here shortly.

  6. dmitry-shibanov commented on Oct 18, 2022

    @dmitry-shibanov
    Contributor

    Hello @cap10morgan. We released a new version of the action with these changes and updated the major tag. Could you please confirm that everything works as expected.

  7. cap10morgan commented on Oct 18, 2022

    @cap10morgan
    ContributorAuthor

    Hello @cap10morgan. We released a new version of the action with these changes and updated the major tag. Could you please confirm that everything works as expected.

    Looks good here!

  8. dmitry-shibanov commented on Oct 18, 2022

    @dmitry-shibanov
    Contributor

    In this case I'm going to close the issue. If you have any concerns feel free to ping us.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

feature requestNew feature or request to improve the current logic

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions