Repository navigation
Include version catalog file in filehash in the Gradle cache key #237
Description
Description:
Add libs.versions.toml or *.versions.toml to the cache key for Gradle dependency caching.
Justification:
Central declaration of dependencies is an incubating Gradle feature that supports centralisation of configuration of dependencies & versions. By convention this is done in a file named libs.versions.toml: https://docs.gradle.org/7.2/userguide/platforms.html#sub:conventional-dependencies-toml
Projects that start using this feature can't practically use the Gradle caching feature in setup-java because the cache key will not change in most cases when dependencies are updated in the TOML file.
Are you willing to submit a PR?
Yes - if this change is acceptable. Edit: no, as I will be using gradle/gradle-build-action@v2 instead which I discovered after raising this issue.
Activity
[-]Include default version catalog file name in cache key[/-][+]Include default version catalog file name in Gradle cache key[/+][-]Include default version catalog file name in Gradle cache key[/-][+]Include version catalog file in filehash in the Gradle cache key[/+]3flex commentedon Oct 14, 2021
Just as an FYI there's less need for this for me personally as I will use gradle/gradle-build-action@v2 which has more robust support for caching dependencies as well as other build outputs like Gradle's build & configuration caches.
dmitry-shibanov commentedon Oct 14, 2021
Hello @3flex. Sorry for the late response. You can publish a pull request with adding new file caching. If you do not want we will add this caching by our own.
We have a minor question, because we're not experts in gradle, could you please advice us the best pattern for caching:
**/libs.versions.tomlor**/*.versions.toml.3flex commentedon Oct 14, 2021
Sorry, I won't be working on a PR.
On the best pattern, I'm not sure -
**/libs.versions.tomlwould capture the conventional, default filename. If someone isn't using the default filename then the file could be named anything as far as I know, so**/*.versions.tomlis probably not that useful. I'd suggest**/libs.versions.tomlto start with.dmitry-shibanov commentedon Oct 14, 2021
We'll prepare a pull request later. We keep the issue opened until the pull request is merged.
Thank you for the response and suggestion @3flex.
feat: support Gradle version catalog