Skip to content

'adopt' is ambigous #160

Closed
Closed

Description

@bmarwell

Description:

Distribution name 'adopt' is ambigous.
There are two VM implementations available under this name, Hotspot and OpenJ9.

Task version:

v2

Platform:

  • Ubuntu
  • macOS
  • Windows

Runner type:

  • Hosted
  • Self-hosted

Repro steps:

distribution: adopt

Expected behavior:

Expected adopt-hotspot and adopt-openj9 instead.

Actual behavior:

One of them is chosen, I do not know which one – probably hotspot?

Activity

  1. dmitry-shibanov commented on Apr 9, 2021

    @dmitry-shibanov
    Contributor

    Hello @bmarwell. Currently the action supports only hotspot releases and "adopt" references hotspot binaries. We have an active pull request to add support for openj9 implementation.

  2. maxim-lobanov commented on May 17, 2021

    @maxim-lobanov
    Contributor

    Merged PR and released version v2.1.0 Link. No need to bump major version since there are no breaking changes.
    Going to update v2 tag to point to v2.1.0 tomorrow. Will be appreciate for any testing and confirmation that it works as expected.

  3. dmitry-shibanov commented on May 20, 2021

    @dmitry-shibanov
    Contributor

    Hello @bmarwell, pull request was merged and v2 tag was also updated. I'm closing the issue. If you have any concerns feel free to reopen the issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugSomething isn't working

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions