Repository navigation
Make the distribution input field optional #154
Description
Description:
V2 requires a distribution input field which brought breaking changes to v1. Make it optional, set default to zulu, thus for most cases, I do not need to change my Github Actions workflow config.
Task version:
v2
Platform:
- Ubuntu
- macOS
- Windows
Runner type:
- Hosted
- Self-hosted
Repro steps:
After upgrading to v2 in this pr, specify the distribution to adopt, the cacerts import behavior failed in Github actions.
See the log:
https://github.com/hantsy/jakartaee9-starter-boilerplate/pull/110/checks?check_run_id=2270373502
You can review the current version(v1) used in the master branch, it works well.
Activity
dmitry-shibanov commentedon Apr 5, 2021
Hello @hantsy. It looks like the issue comes from precached java version not from the task itself. As a solution you can run
keytoolwith sudo or switch distribution tozulu.hantsy commentedon Apr 5, 2021
What is the default distribution in v1? @dmitry-shibanov
In v2 it seems I have to specify the distribution variable, else it does not work. But for back portion compatibility, I think it is better to set a distribution by default internally if not specified, thus I do not need to change very workflow files.
konradpabjan commentedon Apr 5, 2021
Here is a migration guide for
v1tov2. If you want to maintain the same behavior asv1you need to specifyzulu. See: https://github.com/actions/setup-java/blob/main/docs/switching-to-v2.mdhantsy commentedon Apr 6, 2021
Changed to
zuluit works again.[-]The AdoptOpenJDK cacerts is not permitted to write[/-][+]Make the distribution input field optional[/+]dmitry-shibanov commentedon Apr 6, 2021
Based on ADR we're not planing to make distribution's field optional. If you want to stay with zulu distribution you can see migration guide for
v1tov2here. We're going to track the initial problem in our repository: actions/runner-images#3117