You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Liberica SDKMAN patch releases still fail to resolve in v6.1.0 #1290
Description:
Liberica patch releases referenced through .sdkmanrc still fail to resolve after #1268. Follow-up to #1267, specifically #1267 (comment).
The real BellSoft API uses X.Y.Z.P+B, while SDKMAN uses X.Y.Z+P.B. The current converter constructs the version from feature/interim/update fields and preserves only the suffix after +, dropping the patch component P. Existing compound-build tests mock SDKMAN-formatted API versions instead of the actual BellSoft format.
Task version:
v6.1.0 and current main, both at b843ebf9b913146b38da2eaa7aeddf76074ae1ad when verified.
Platform:
Ubuntu
macOS
Windows
Runner type:
Hosted
Self-hosted
Repro steps:
Commit a .sdkmanrc containing java=17.0.20+1.1-librca.
Live API verification also confirms the original Java 25 case:
SDKMAN request
BellSoft API version
Current normalized version
17.0.20+1.1
17.0.20.1+1
17.0.20+1
25.0.4+1.1
25.0.4.1+1
25.0.4+1
The CRaC API variant 17.0.20.1+2 further confirms patch/build ordering (+1.2, not +2.1); adding CRaC package support is not required to fix standard JDK resolution.
Expected behavior:
Resolve SDKMAN's 17.0.20+1.1-librca to BellSoft's 17.0.20.1+1 artifact, and similarly for 25.0.4+1.1-librca. Preserve distinct patch/build identities, exact matching, and numeric ordering. Add regression coverage using realistic BellSoft API metadata.
Actual behavior: No matching version found for SemVer '17.0.20+1.1'.
src/distributions/liberica/installer.ts:168–179 drops the fourth version component. The fixture at __tests__/distributors/liberica-installer.test.ts:256–287 incorrectly represents API releases as 25.0.4+1.1, masking the failure.
Activity
Fix Liberica SDKMAN patch release resolution (actions#1291)